Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Changes Machine learning overview UI text #64625

Merged
merged 5 commits into from
Apr 29, 2020

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Apr 28, 2020

Summary

This PR makes some changes in the text of the Machine learning overview screen to make it shorter and to improve readability.

Checklist

@szabosteve szabosteve added release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0 :ml labels Apr 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@elastic elastic deleted a comment from kibanamachine Apr 28, 2020
@elastic elastic deleted a comment from kibanamachine Apr 28, 2020
@szabosteve szabosteve marked this pull request as ready for review April 28, 2020 13:54
@szabosteve szabosteve requested a review from a team as a code owner April 28, 2020 13:54
@szabosteve szabosteve requested review from walterra and lcawl April 28, 2020 13:54
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor punctuation suggestions, otherwise LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@szabosteve szabosteve merged commit a38c11c into elastic:master Apr 29, 2020
@szabosteve szabosteve deleted the ml.ui.rev branch April 29, 2020 11:58
@szabosteve szabosteve added the backport:skip This commit does not require backporting label Apr 29, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 29, 2020
* master:
  [ML] Changes Machine learning overview UI text (elastic#64625)
  [Uptime] Migrate client to New Platform (elastic#55086)
  Slim vis type timeseries (elastic#64631)
  [Telemetry] Fix inconsistent search behaviour in Advanced Settings (elastic#64510)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 29, 2020
* alerting/np-migration: (64 commits)
  [ML] Changes Machine learning overview UI text (elastic#64625)
  [Uptime] Migrate client to New Platform (elastic#55086)
  Slim vis type timeseries (elastic#64631)
  [Telemetry] Fix inconsistent search behaviour in Advanced Settings (elastic#64510)
  removed unneeded dep and file
  [SIEM] Create template timeline (elastic#63136)
  load react component lazily in so management section (elastic#64285)
  Cleanup .eslingignore and add target (elastic#64617)
  [Ingest] Support yaml variables in datasource (elastic#64459)
  typescript-ify portions of src/optimize (elastic#64688)
  [ngSanitize] add explicit dependencies to all uses of `ngSanitize` angular module (elastic#64546)
  Consolidate downloading plugin bundles to bootstrap script (elastic#64685)
  [Maps] disable edit layer button when flyout is open for add layer or map settings (elastic#64230)
  chore(NA): add async import into infra plugin to reduce apm bundle size (elastic#63292)
  [Maps] fix edit filter (elastic#64586)
  [SIEM][Detections] Adds large list support using REST endpoints
  Replace a number of any-ed styled(eui*) with accurate types (elastic#64555)
  [Endpoint] Recursive resolver children (elastic#61914)
  [ML] Fix new job wizard with multiple indices (elastic#64567)
  Use short URLs for legacy plugin deprecation warning (elastic#64540)
  ...
@lcawl lcawl mentioned this pull request Apr 29, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants