Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test in alert details page #64572

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

mikecote
Copy link
Contributor

@mikecote mikecote commented Apr 27, 2020

Fixes #62676

The tests were flaky in the scenario it took task manager longer than usual to run the newly created alert. In this PR, I'm moving the wait for initial state before loading the UI to ensure all the data necessary is in place.

Flaky runner: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/407/

@mikecote mikecote added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.8.0 v7.7.1 labels Apr 27, 2020
@mikecote mikecote self-assigned this Apr 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mikecote mikecote marked this pull request as ready for review April 28, 2020 12:04
@mikecote mikecote requested a review from a team as a code owner April 28, 2020 12:04
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecote mikecote merged commit e09e6a2 into elastic:master Apr 28, 2020
mikecote added a commit to mikecote/kibana that referenced this pull request Apr 28, 2020
mikecote added a commit to mikecote/kibana that referenced this pull request Apr 28, 2020
@mikecote
Copy link
Contributor Author

Note: Holding off merging into 7.7 until the branch is upgraded to 7.7.1

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 30, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 4, 2020
mikecote added a commit that referenced this pull request May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.1 v7.8.0 v8.0.0
Projects
None yet
4 participants