-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor action messaging to report on No Data state #64365
Conversation
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
@elasticmachine merge upstream |
Per discussion with @hbharding I pushed a change to the default action message from
to
Each alert reason will now be separated by line breaks instead of semicolons (log messages convert line breaks to semicolons anyway) |
x-pack/plugins/infra/public/components/alerting/metrics/metric_threshold_alert_type.ts
Show resolved
Hide resolved
# Conflicts: # x-pack/plugins/infra/public/components/alerting/metrics/expression.tsx
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Breaking Change Note
This causes a breakage in the beta feature of Metrics Alerting, and is therefore okay to release in 7.8.
Metrics alerts will no longer expose
context.valueOf
,context.metricOf
, orcontext.thresholdOf
to action messages. These are replaced by the variablecontext.reason
, which explains the reason for the alert firing and automatically includes the metric, threshold, and current value of all configured conditions.Any alerts configured in 7.7 will still function as normally, but their action messages may no longer provide useful information and have to be reconfigured. The new default action message will show an example of how to use
context.reason
.Summary
Closes #64080
context.alertState
andcontext.reason
values to action messagesalertState
can beALERT
,NO DATA
, orERROR
(Adding messaging forOK
states will come in a later PR)reason
is a description of why thealertState
was triggered: forALERT
it describes the current metric value(s) that have crossed a configured threshold, forNO DATA
it lists metrics that haven't reported data, and forERROR
it lists metrics that could not be queriedNO DATA
/ERROR
states. It is unchecked by default.Note: Tooltip changed to "or if the alert fails to query Elasticsearch" in a commit after this screenshot was taken to better comply with EUI writing style
Checklist