Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NP] Migrate uiSettings owned by Kibana app #64321

Merged
merged 25 commits into from
May 15, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
4efa64e
Migrate uiSettings
maryia-lapata Apr 23, 2020
77b75cd
Migrate uiSettings to visTypeVislib
maryia-lapata Apr 24, 2020
db60224
Refactoring
maryia-lapata Apr 24, 2020
6761400
Update index_pattern.ts
maryia-lapata Apr 24, 2020
cf723a9
Merge remote-tracking branch 'kibana/master' into ui_settings
maryia-lapata Apr 24, 2020
83b29f7
Merge master /fix conflicts
kertal Apr 27, 2020
c0c8327
Add defaults for fixing failing tests
kertal Apr 28, 2020
1d21edd
Merge master /fix conflicts
kertal Apr 28, 2020
33587b0
Merge master /fix conflicts
kertal Apr 30, 2020
75213b8
Merge remote-tracking branch 'upstream/master' into ui_settings
kertal May 4, 2020
1b5e5a8
Merge remote-tracking branch 'upstream/master' into ui_settings
kertal May 4, 2020
205dd54
Move META_FIELDS_SETTING, DOC_HIGHLIGHT_SETTING to data plugin.ts
kertal May 4, 2020
26b3b1a
Update server.api.md
kertal May 5, 2020
daa18f6
Merge master /fix conflicts
kertal May 5, 2020
d9d7cf4
Merge remote-tracking branch 'upstream/master' into ui_settings
kertal May 6, 2020
7769016
Merge master /fix conflicts
kertal May 11, 2020
72e29b7
Refactor table_list_view.tsx to no longer get PER_PAGE_SETTING by uiS…
kertal May 11, 2020
785c3a5
Migrate graph usage of saved_objects module constants for uiSettings …
kertal May 11, 2020
185d29c
Adapt Visualize code
kertal May 13, 2020
17c291a
Cleanups
kertal May 13, 2020
5df721d
Adapt dashboard
kertal May 13, 2020
ca7915a
Merge master /fix conflicts
kertal May 13, 2020
8d4b8c2
Fix types
kertal May 14, 2020
6119854
Merge remote-tracking branch 'upstream/master' into ui_settings
kertal May 15, 2020
fe8dc06
Remove chart plugin logging
kertal May 15, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove chart plugin logging
  • Loading branch information
kertal committed May 15, 2020
commit fe8dc0655c211e7256cdc46be9c71f418785abcb
4 changes: 1 addition & 3 deletions src/plugins/charts/server/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
* under the License.
*/

import { PluginInitializerContext } from 'kibana/server';
import { ChartsServerPlugin } from './plugin';

export const plugin = (initContext: PluginInitializerContext) =>
new ChartsServerPlugin(initContext);
export const plugin = () => new ChartsServerPlugin();
14 changes: 2 additions & 12 deletions src/plugins/charts/server/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,11 @@

import { i18n } from '@kbn/i18n';
import { schema } from '@kbn/config-schema';

import { PluginInitializerContext, CoreSetup, CoreStart, Plugin, Logger } from 'kibana/server';
import { CoreSetup, Plugin } from 'kibana/server';
import { COLOR_MAPPING_SETTING } from '../common';

export class ChartsServerPlugin implements Plugin<object, object> {
private readonly logger: Logger;

constructor(initializerContext: PluginInitializerContext) {
this.logger = initializerContext.logger.get();
}

public setup(core: CoreSetup) {
this.logger.debug('charts: Setup');

core.uiSettings.register({
[COLOR_MAPPING_SETTING]: {
name: i18n.translate('charts.advancedSettings.visualization.colorMappingTitle', {
Expand All @@ -53,8 +44,7 @@ export class ChartsServerPlugin implements Plugin<object, object> {
return {};
}

public start(core: CoreStart) {
this.logger.debug('charts: Started');
public start() {
return {};
}

Expand Down