Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Region Maps to NP #64272

Merged
merged 16 commits into from
May 7, 2020
Merged

Conversation

kindsun
Copy link
Contributor

@kindsun kindsun commented Apr 22, 2020

Updates Region Maps dependencies and migrates it to the New Platform. Very similar to #64668, but less complicated:

  • Migrated Region Maps to NP location
  • Added small server presence to serve config
  • Config now available via UI setup

@kindsun kindsun force-pushed the np-migrate-region-maps branch from 66bf7ec to 82a0dfa Compare April 28, 2020 15:02
@kindsun kindsun added Feature:NP Migration Feature:Region Map release_note:skip Skip the PR/issue when compiling release notes [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.8.0 v8.0.0 labels Apr 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kindsun kindsun force-pushed the np-migrate-region-maps branch from 82a0dfa to b062fdc Compare April 29, 2020 02:20
@kindsun kindsun marked this pull request as ready for review April 30, 2020 17:59
@kindsun kindsun requested a review from thomasneirynck April 30, 2020 18:00
@lukeelmers
Copy link
Member

In #64780 we had to disable a region maps test in our suite of functional tests for expressions, because it wasn't yet migrated to the new platform where the tests run from.

If that PR merges before this one, would you mind re-enabling the test in this PR?

@kindsun
Copy link
Contributor Author

kindsun commented May 6, 2020

If that PR merges before this one, would you mind re-enabling the test in this PR?

@lukeelmers Will do, thanks for the heads up!

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in chrome and works. 🎉

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kindsun kindsun merged commit 7d0ac59 into elastic:master May 7, 2020
@kindsun kindsun deleted the np-migrate-region-maps branch May 7, 2020 17:22
kindsun pushed a commit to kindsun/kibana that referenced this pull request May 7, 2020
kindsun pushed a commit that referenced this pull request May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:NP Migration Feature:Region Map release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants