Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display node 75% view submenus #64121
Display node 75% view submenus #64121
Changes from 67 commits
c4ab6e2
cfd95e8
2c7b279
5aef930
8ea107d
ab58823
42c9a3b
f166d6d
6cb887b
36fe414
2429b4b
41f4a79
8c454d4
747cd6e
72665e0
a98cd7a
6e75074
5529b7e
29e0018
c7c22bf
5631113
e8d48db
01ea4a1
c64d990
c7edee7
2d1b3f2
4ad185d
de039bf
ffdb41f
3a6314b
12af60b
ecf85db
84ffd8b
7fc4d0b
8c46844
f1863c5
0620a86
ea3aa85
4842833
03237e6
1d09e38
7395f6d
ea0c436
e1d5cc9
211df54
e2d87f4
fe22f98
c0bcc25
e375fa7
eaea02e
7bb0c30
ae14c1e
5a4819c
7b8aa36
e019815
2d7523a
17dfe3c
2413c93
d08f414
2f90697
848f659
70fa593
66fc653
235ebd5
080e112
7e03a25
f39f4cd
78b0531
f601477
3d52b8c
1985a31
91f2bd6
c05de64
5bb0411
7e85044
c06da13
e742cce
fe978f6
7750c97
9e07c11
002d631
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it necessary to set an Error object in redux state? What is the English text in the error object used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an object that indicates there is an Error. The language in the Error could help a user understand why the Error was created. Functionally, it is equivalent to an object - it just has some extra semantics (this is an Error). I'd like to change this to something you like better: Can I just use a normal object with an {errorMessage: ``}? Or a string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the error message being shown to the user? If not, I think having it in the code is confusing. If so, it should be translated, and it should probably be defined in the view part of the app.