-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display node 75% view submenus #64121
Merged
bkimmel
merged 81 commits into
elastic:master
from
bkimmel:resolver/lay-in-submenu-options
May 18, 2020
Merged
Changes from 1 commit
Commits
Show all changes
81 commits
Select commit
Hold shift + click to select a range
c4ab6e2
cleanup: move submenus into a general component
cfd95e8
remove unnecessary useState import
2c7b279
referral for help
5aef930
Use EUISelectable for options list
8ea107d
adding EUISelectable
ab58823
user-select off to fix bug Jonny found
42c9a3b
Revert "user-select off to fix bug Jonny found"
f166d6d
straighten corners on menu open to match mocks
6cb887b
adding type information for related events
36fe414
refine type information for related events
2429b4b
Node option submenus take waiting prop
41f4a79
Merge remote-tracking branch 'upstream/master' into resolver/lay-in-s…
8c454d4
merge upstream
747cd6e
stub selector for related events
72665e0
provision component with selected relatedEvents
a98cd7a
shape reducder
6e75074
adjust reducer for consistency
5529b7e
adding request logic to middleware
29e0018
investigating problems with /events and CLI
c7c22bf
pulling through selector
5631113
test rendering in component
e8d48db
cleanup unused
01ea4a1
more cleanup
c64d990
cleanup action
c7edee7
fix submenu options typings
2d1b3f2
move utility function off and seal it
4ad185d
fix middleware types
de039bf
adjust model to return Process
ffdb41f
K Qualters review: change action name
3a6314b
lint
12af60b
Add error handling
ecf85db
cleanup reducer
84ffd8b
document selector
7fc4d0b
adding comments to types
8c46844
linting
f1863c5
use built-in EUI loading indicator
0620a86
linting
ea3aa85
node cleanup
4842833
add related category select action
03237e6
Move submenu to import to clear up event_dot
1d09e38
18n format for number
7395f6d
add comments to submenu
ea0c436
add related alerts action
e1d5cc9
Merge branch 'master' into resolver/lay-in-submenu-options
elasticmachine 211df54
lint selector
e2d87f4
D Plumlee review: remove unnecessary bindings to type
fe22f98
D Plumlee review: remove comments
c0bcc25
add comments to relatedEventOptions breakouts
e375fa7
R Austin review: move logic from reducer to selector
eaea02e
linting
7bb0c30
D Plumlee / R Austin review: i18n for event categories
ae14c1e
lint resolver node
5a4819c
R Austin Review: adjust middleware, rewrites for clarity, fixing types
7b8aa36
R Austin review: Move category display names to view
e019815
R Austin review: remove all symbols
2d7523a
R Austin review: refactor memos for clarity
17dfe3c
add comment
2413c93
K Qualters review: destructure arguments
d08f414
K Qualters review: add more ECS event types to Map
2f90697
add comments for clarification
848f659
Merge branch 'master' into resolver/lay-in-submenu-options
elasticmachine 70fa593
Merge branch 'master' into resolver/lay-in-submenu-options
elasticmachine 66fc653
D Plumlee review: Display unknown for unmatched categories
235ebd5
R Austin review: Call i18n with static values
080e112
D Plumlee review: remove reselect call from selector where it's not n…
7e03a25
R Austin / J Brown review: Add test coverage for selectors
f39f4cd
Merge branch 'master' into resolver/lay-in-submenu-options
elasticmachine 78b0531
Merge branch 'master' into resolver/lay-in-submenu-options
elasticmachine f601477
R Austin review: undo Memos, add comments
3d52b8c
Merge remote-tracking branch 'origin/resolver/lay-in-submenu-options'…
1985a31
R Austin review: adjust type on submenu for readability
91f2bd6
R Austin review: move selectable options to state hook
c05de64
R Austin review: simplify type, remove memo, remove inert return
5bb0411
R Austin review: add comments, move testing instantiation
7e85044
R Austin review: remove unnecessary type check
c06da13
R Austin review: direct return
e742cce
R Austin review: Add comments to actions
fe978f6
R Austin review: change payload for failed action
7750c97
R Austin review: More specific related type?
9e07c11
R Austin review: Remove Error construction
002d631
R Austin review: mark relatedEventInfo non-optional
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📏 Don't: Mark things as optional (even if it seems they could/should be) unless you have code that uses them that way. Do: Mark most things as required in most cases.