-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix endpoint host list test #64104
Fix endpoint host list test #64104
Conversation
fix location of es archive file
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
Pinging @elastic/endpoint-management (Team:Endpoint Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Just minor comment (optional)
this.tags('ciGroup7'); | ||
const sleep = (ms = 100) => new Promise(resolve => setTimeout(resolve, ms)); | ||
before(async () => { | ||
await esArchiver.load('endpoint/metadata/api_feature'); | ||
await pageObjects.common.navigateToUrlWithBrowserHistory('endpoint', '/hosts'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these two lines could be removed, since all subsequent test blocks (describe()
) already do this navigation - unless: this is meant for the UI to run the "setup" where we call ingest to install the package (mabye?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was a concern from a timing perspective. If you feel it is not needed I can remove them @paul-tavares.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove the load. It was an oversight.
jenkins test this |
@elasticmachine merge upstream |
…m/charlie-pichette/kibana into 63621-Fix-Endpoint-Host-List-Test
@elasticmachine merge upstream |
@elasticmachine test this please |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / kibana-xpack-agent / X-Pack Endpoint Functional Tests.x-pack/test/functional_endpoint/apps/endpoint/host_list·ts.endpoint host list with data finds titleStandard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / X-Pack Endpoint Functional Tests.x-pack/test/functional_endpoint/apps/endpoint/host_list·ts.endpoint host list with data finds titleStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
Summary
The endpoint host list tests were failing due to not waiting for data to load. Added a check to verify the data loads. Also added steps to the after block for the test where we remove data.
fixes #63621
Checklist
Delete any items that are not applicable to this PR.
For maintainers