-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code coverage: run more configs with functional tests #63680
Code coverage: run more configs with functional tests #63680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dmlemeshko ! Could you also add this one:
require.resolve('../test/plugin_functional/config.ts')
That has some tests for our Resolver embeddable used in the endpoint app.
cc: @oatkiller
Out of curiosity, how do we choose which test suites should be included for code coverage? I know we have the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@legrego "Functional" code coverage is expected to run all the Kibana client-side tests, that can be executed in Chrome. |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
@dmlemeshko did you want to backport this to 7.x? I'm backporting #63430 and have conflicts with |
Summary
This PR extends set of functional tests configs that we execute to collect code coverage:
Note: I think I didn't miss any other config with functional tests (running in Chrome browser), but if you think I did - please let me know.
Code coverage report is available here
Before:
After:
Endpoint plugin sources are listed in the report now