[FTR]: add chromium-based Edge browser support #63566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
added
v7.7.1
v7.8.0
v8.0.0
release_note:skip
watson
approved these changes
Apr 15, 2020
|
@LeeDr could you give a test for Edge locally, just to confirm everything is fine on Windows |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Apr 16, 2020
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Apr 16, 2020
dmlemeshko
added a commit
to dmlemeshko/kibana
that referenced
this pull request
Apr 16, 2020
dmlemeshko
added a commit
that referenced
this pull request
Apr 16, 2020
dmlemeshko
added a commit
that referenced
this pull request
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add new chromium-based Edge browser in FTR
node scripts/functional_test_runner --config test/functional/config.edge.jsOriginal PR #61684 was reverted due to
node-gypcompilation issue caused byrefdependency inwindows-registryused byms-chromium-edge-driverpackage.I updated
ms-chromium-edge-driverto useregeditinstead ofwindows-registry, hopefully the issue is solved now.