-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM] Server cutover to New Platform #63430
Changes from all commits
cb3c4f8
27f5eaa
4caf083
e3440ea
07bea5b
f24c1db
1b36855
e528bea
7faeeed
c3c487f
faa3d93
3b66124
6030b1b
c4ceebb
c6cdbc2
06c62cf
b36cdf3
a8f272b
6b09a1f
70aa11a
4baa5bb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
# Auto-collapse generated files in GitHub | ||
# https://help.github.com/en/articles/customizing-how-changed-files-appear-on-github | ||
x-pack/legacy/plugins/siem/public/graphql/types.ts linguist-generated=true | ||
x-pack/legacy/plugins/siem/server/graphql/types.ts linguist-generated=true | ||
x-pack/legacy/plugins/siem/public/graphql/introspection.json linguist-generated=true | ||
|
This file was deleted.
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -1,16 +1,10 @@ | ||||||||||
{ | ||||||||||
"author": "Elastic", | ||||||||||
"name": "siem", | ||||||||||
"name": "siem-legacy-ui", | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change is just to explicitly state that the client UI is still on the old platform (and disambiguate from the non-legacy package.json), correct? Are there any downstream effects of changing the app name here, or does all of the magic that keys off app name/id/title happen from what is set in legacy kibana/x-pack/legacy/plugins/siem/public/register_feature.ts Lines 11 to 14 in 27f5eaa
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @spong correct, the name here is just to disambiguate; there's a check in the build process that actually verifies that each package.json has a unique name. I have not seen anything to indicate that this name affects the build process but I'll verify that with platform. |
||||||||||
"version": "8.0.0", | ||||||||||
"private": true, | ||||||||||
"license": "Elastic-License", | ||||||||||
"scripts": { | ||||||||||
"extract-mitre-attacks": "node scripts/extract_tactics_techniques_mitre.js & node ../../../../scripts/eslint ./public/pages/detection_engine/mitre/mitre_tactics_techniques.ts --fix", | ||||||||||
"build-graphql-types": "node scripts/generate_types_from_graphql.js", | ||||||||||
"cypress:open": "../../../node_modules/.bin/cypress open", | ||||||||||
"cypress:run": "../../../node_modules/.bin/cypress run --spec ./cypress/integration/**/*.spec.ts --reporter ../../../node_modules/cypress-multi-reporters --reporter-options configFile=./reporter_config.json; status=$?; ../../../node_modules/.bin/mochawesome-merge --reportDir ../../../../target/kibana-siem/cypress/results > ../../../../target/kibana-siem/cypress/results/output.json; ../../../../node_modules/.bin/marge ../../../../target/kibana-siem/cypress/results/output.json --reportDir ../../../../target/kibana-siem/cypress/results; mkdir -p ../../../../target/junit && cp ../../../../target/kibana-siem/cypress/results/*.xml ../../../../target/junit/ && exit $status;", | ||||||||||
"cypress:run-as-ci": "node ../../../../scripts/functional_tests --config ../../../test/siem_cypress/config.ts" | ||||||||||
}, | ||||||||||
"scripts": {}, | ||||||||||
"devDependencies": { | ||||||||||
"@types/lodash": "^4.14.110", | ||||||||||
"@types/js-yaml": "^3.12.1", | ||||||||||
|
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -8,7 +8,6 @@ import { EuiBadge, EuiToolTip, IconType } from '@elastic/eui'; | |||
import React from 'react'; | ||||
import styled from 'styled-components'; | ||||
|
||||
import { Omit } from '../../../common/utility_types'; | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think (as per my IDE) this was the last ref to this export:
|
||||
import { DragEffects, DraggableWrapper } from '../drag_and_drop/draggable_wrapper'; | ||||
import { escapeDataProviderId } from '../drag_and_drop/helpers'; | ||||
import { getEmptyStringTag } from '../empty_value'; | ||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we are not using this elsewhere in the codebase. Do you think we could just delete
default_index_pattern.ts
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That file was meant to be deleted, good catch 👍