[Maps] Show spatial filters on map to provide context when for active filters #63406

nreese · 2020-04-13T20:36:11Z

With this PR, the map will show the spatial filter so users have some reference of where their filters are getting applied.

This PR is just a MVP and there are a lot of features that could be added in the future, including:

ability to edit shape
ability to customize style spatial filter layer. This will require map properties
ability to turn functionality off. This will require map properties

…rs_layer

elasticmachine · 2020-04-13T20:36:14Z

Pinging @elastic/kibana-gis (Team:Geo)

jsanz

Nice UI touch 👏

If anything, for readability, I would add a space after the comma, and four decimals should be enough since that's around 10 meters precision, even we may want to leave that as a future config parameter for the map since this may make sense to tweak for very specific city-level mapping.

Going further (maybe too much), could the number of decimals be derived from the distance? For a 600km filter having no decimals is ok, for a 500m filter having 4 decimals would not be enough. Apart from the readability criteria, that horizontal space for filter pills feels expensive, so some logic to use it well makes sense to me. What do you think?

Tested locally on Chromium

…sLayer

nreese · 2020-04-14T14:37:44Z

x-pack/legacy/plugins/maps/public/connected_components/map/mb/mb.utils.test.js

@@ -250,40 +254,4 @@ describe('mb/utils', () => {
    const nextStyle = getMockStyle(nextLayerListOrder);
    expect(orderedStyle).toEqual(nextStyle);
  });
-
-  test('should reorder foo and bar and remove baz', async () => {


Removed these tests because they do not test anything new.

nreese · 2020-04-14T16:48:27Z

If anything, for readability, I would add a space after the comma, and four decimals should be enough since that's around 10 meters precision, even we may want to leave that as a future config parameter for the map since this may make sense to tweak for very specific city-level mapping.
Going further (maybe too much), could the number of decimals be derived from the distance? For a 600km filter having no decimals is ok, for a 500m filter having 4 decimals would not be enough. Apart from the readability criteria, that horizontal space for filter pills feels expensive, so some logic to use it well makes sense to me. What do you think?

Good idea. I have updated the logic for the distance filter generation to lower precision as the distance increases and the precision is not as useful

jsanz

I have updated the logic for the distance filter generation to lower precision as the distance increases and the precision is not as useful

Nice!! 👏 👏

From the functional point of view, I have nothing else to comment on, great new feature.

nreese · 2020-04-16T12:03:14Z

@elasticmachine merge upstream

nreese · 2020-04-16T23:40:51Z

@elasticmachine merge upstream

…rs_layer

… spatial_filters_layer

nreese · 2020-04-20T13:52:16Z

@elasticmachine merge upstream

… spatial_filters_layer

thomasneirynck

I like it, but I'm wondering if we should introduce this point-blank. (?)

The visual effect is quite different, as filters now just show. Without ability to edit the styling, users might be taken aback with the sudden visual change.

Additionally, once something is on the map I'd expect to click on it. e.g. to open a tooltip and remove the filter by clicking on the shape.

It works the other direction too. Selecting a filter pill, there's no indication what filter this actually represents (e.g/ by highlighting the shape on the map).

I'm thinking the introduction of #63714 would help bridge the cap. We could include a flag to turn on/off the visual feedback for filters. Then, we have some framework to add more advanced features and functionality over time instead of trying to get it right at first pass.

What do you think?

thomasneirynck · 2020-04-21T13:34:42Z

x-pack/plugins/maps/public/elasticsearch_geo_utils.js

+export function extractFeaturesFromFilters(filters) {
+  const features = [];
+  filters
+    .filter(filter => {


I'm wondering if there's another way to determine whether a filter is "spatial". Right now, manually added filters do not show.

as discussed, keeping this for a later improvement. Unless users edit DSL manually, ther;es no way in Kibana to add a spatial filter except for using Maps

jsanz · 2020-04-21T16:31:06Z

Maybe we can use a less intrusive styling like a lighter background and dashed outline? Definitely something we may want to expose as a setting, but not sure if it would be for each map individually or a more broad setting at Space or Kibana level.

Apart from the styling, having the filtered outline highlighted when editing would be great, being able to edit it on the map even better!

…rs_layer

nreese · 2020-04-22T15:01:52Z

I like it, but I'm wondering if we should introduce this point-blank. (?)
The visual effect is quite different, as filters now just show. Without ability to edit the styling, users might be taken aback with the sudden visual change.

@thomasneirynck Now that map settings has merged, I updated map settings to allow turning feature off and configuring styling of spatial filter styling.

Additionally, once something is on the map I'd expect to click on it. e.g. to open a tooltip and remove the filter by clicking on the shape.

Great ideas but should be part of another PR. Just showing the filters provides a lot of value and context and we can add to the feature at a later date.

thomasneirynck

Really fun, especially in Dashboard context.

Some minor suggestions in-line.

as discussed, map-settings are not taken into account when determining saved/unsaved state. Right now, when a user leaves Maps, it does not give users a warning to save changes. Agreed to do in separate PR.

x-pack/plugins/maps/public/components/alpha_slider.tsx

x-pack/plugins/maps/public/connected_components/map/mb/view.js

x-pack/plugins/maps/public/selectors/map_selectors.js

x-pack/plugins/maps/public/connected_components/map/mb/view.js

x-pack/plugins/maps/public/connected_components/map_settings_panel/spatial_filters_panel.tsx

thomasneirynck · 2020-04-22T19:02:37Z

x-pack/plugins/maps/public/elasticsearch_geo_utils.js

+export function extractFeaturesFromFilters(filters) {
+  const features = [];
+  filters
+    .filter(filter => {


as discussed, keeping this for a later improvement. Unless users edit DSL manually, ther;es no way in Kibana to add a spatial filter except for using Maps

thomasneirynck

🧨

kibanamachine · 2020-04-22T21:01:54Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 5ea8f0c

History

💚 Build #42488 succeeded 0e8e8f4
💔 Build #42470 failed 3b3c2e4
💔 Build #42310 failed d3a90b5
💚 Build #42054 succeeded e10efdf
💚 Build #41860 succeeded 5743972

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

… filters (elastic#63406) * [Maps] show spatial filters * pass data into __dataRequests * extractFeaturesFromFilters * geo_shape support * putting it all together * lower alpha * update removeOrphanedSourcesAndLayers to avoid removing spatialFiltersLayer * change array iteration to forEach * use less precision when distance filter covers larger distances * fix double import * add map settings for to configure spatial filters layer * add map settings alpha slider * finish rest of map settings * review feedback Co-authored-by: Elastic Machine <[email protected]>

… filters (#63406) (#64250) * [Maps] show spatial filters * pass data into __dataRequests * extractFeaturesFromFilters * geo_shape support * putting it all together * lower alpha * update removeOrphanedSourcesAndLayers to avoid removing spatialFiltersLayer * change array iteration to forEach * use less precision when distance filter covers larger distances * fix double import * add map settings for to configure spatial filters layer * add map settings alpha slider * finish rest of map settings * review feedback Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

nreese added 8 commits April 10, 2020 15:14

[Maps] show spatial filters

64d64ab

Merge branch 'master' of github.com:elastic/kibana into spatial_filte…

f8203cd

…rs_layer

pass data into __dataRequests

80d330f

extractFeaturesFromFilters

5afda7f

Merge branch 'master' of github.com:elastic/kibana into spatial_filte…

7db5388

…rs_layer

geo_shape support

8f02a9b

putting it all together

24fd1d2

lower alpha

87d1484

nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.8.0 labels Apr 13, 2020

nreese requested review from jsanz and thomasneirynck April 13, 2020 20:36

nreese requested a review from a team as a code owner April 13, 2020 20:36

nreese mentioned this pull request Apr 13, 2020

[Maps] Map properties #62769

Closed

jsanz requested changes Apr 14, 2020

View reviewed changes

nreese changed the title ~~Spatial filters layer~~ [Maps] Show spatial filters on map to provide context when for active filters Apr 14, 2020

update removeOrphanedSourcesAndLayers to avoid removing spatialFilter…

51deb4b

…sLayer

nreese commented Apr 14, 2020

View reviewed changes

nreese added 2 commits April 14, 2020 08:38

change array iteration to forEach

b0e6e66

use less precision when distance filter covers larger distances

80a6ce4

nreese requested a review from jsanz April 14, 2020 16:48

jsanz approved these changes Apr 15, 2020

View reviewed changes

elasticmachine and others added 2 commits April 16, 2020 08:03

Merge branch 'master' into spatial_filters_layer

f9fdac1

fix double import

77efd16

elasticmachine and others added 3 commits April 16, 2020 19:40

Merge branch 'master' into spatial_filters_layer

8ae8928

Merge branch 'master' of github.com:elastic/kibana into spatial_filte…

6989dcd

…rs_layer

Merge branch 'spatial_filters_layer' of github.com:nreese/kibana into…

b86d3d5

… spatial_filters_layer

elasticmachine and others added 3 commits April 20, 2020 09:52

Merge branch 'master' into spatial_filters_layer

5743972

merge with master

f9aea21

Merge branch 'spatial_filters_layer' of github.com:nreese/kibana into…

e10efdf

… spatial_filters_layer

thomasneirynck reviewed Apr 21, 2020

View reviewed changes

nreese added 5 commits April 21, 2020 16:42

merge with master

d3a90b5

add map settings for to configure spatial filters layer

84af9dc

Merge branch 'master' of github.com:elastic/kibana into spatial_filte…

3b3c2e4

…rs_layer

add map settings alpha slider

624a092

finish rest of map settings

0e8e8f4

nreese requested a review from thomasneirynck April 22, 2020 15:01

thomasneirynck reviewed Apr 22, 2020

View reviewed changes

review feedback

5ea8f0c

nreese requested a review from thomasneirynck April 22, 2020 19:18

thomasneirynck approved these changes Apr 22, 2020

View reviewed changes

nreese merged commit f7ea9b9 into elastic:master Apr 22, 2020

nreese mentioned this pull request Apr 22, 2020

[7.x] [Maps] Show spatial filters on map to provide context when for active filters (#63406) #64250

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps] Show spatial filters on map to provide context when for active filters #63406

[Maps] Show spatial filters on map to provide context when for active filters #63406

nreese commented Apr 13, 2020

elasticmachine commented Apr 13, 2020

jsanz left a comment

nreese Apr 14, 2020

nreese commented Apr 14, 2020

jsanz left a comment

nreese commented Apr 16, 2020

nreese commented Apr 16, 2020

nreese commented Apr 20, 2020

thomasneirynck left a comment

thomasneirynck Apr 21, 2020

thomasneirynck Apr 22, 2020

jsanz commented Apr 21, 2020

nreese commented Apr 22, 2020

thomasneirynck left a comment

thomasneirynck Apr 22, 2020

thomasneirynck left a comment

kibanamachine commented Apr 22, 2020

[Maps] Show spatial filters on map to provide context when for active filters #63406

[Maps] Show spatial filters on map to provide context when for active filters #63406

Conversation

nreese commented Apr 13, 2020

elasticmachine commented Apr 13, 2020

jsanz left a comment

Choose a reason for hiding this comment

nreese Apr 14, 2020

Choose a reason for hiding this comment

nreese commented Apr 14, 2020

jsanz left a comment

Choose a reason for hiding this comment

nreese commented Apr 16, 2020

nreese commented Apr 16, 2020

nreese commented Apr 20, 2020

thomasneirynck left a comment

Choose a reason for hiding this comment

thomasneirynck Apr 21, 2020

Choose a reason for hiding this comment

thomasneirynck Apr 22, 2020

Choose a reason for hiding this comment

jsanz commented Apr 21, 2020

nreese commented Apr 22, 2020

thomasneirynck left a comment

Choose a reason for hiding this comment

thomasneirynck Apr 22, 2020

Choose a reason for hiding this comment

thomasneirynck left a comment

Choose a reason for hiding this comment

kibanamachine commented Apr 22, 2020

💚 Build Succeeded

History