Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest overview page #63214

Merged
merged 15 commits into from
Apr 20, 2020
Merged

Ingest overview page #63214

merged 15 commits into from
Apr 20, 2020

Conversation

hbharding
Copy link
Contributor

@hbharding hbharding commented Apr 10, 2020

Related: #62113

Initial PR for Ingest Manager overview page. I added messaging about being in a "alpha release" at the bottom of all pages.

image

@hbharding hbharding added in progress Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:alpha1 Group issues for ingest management alpha1 labels Apr 10, 2020
@hbharding hbharding requested a review from a team April 10, 2020 01:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@hbharding
Copy link
Contributor Author

I think this is ready to merge. I'll need help in a separate issue/PR to finish the rest:

  • the numbers are hard coded. hook up to real data
  • datastreams doesn't link anywhere
  • the fleet panel should not appear if fleet is disabled

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0 labels Apr 17, 2020
<Message>
<p>
<small>
<strong>Alpha release</strong> – Ingest Manager is under active development and is not
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use a FormattedMessage here so we can have translations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments but when it's fixed 🚀(and CI pass :) )

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@hbharding hbharding merged commit 44a2c2f into elastic:master Apr 20, 2020
hbharding pushed a commit to hbharding/kibana that referenced this pull request Apr 20, 2020
* use fixed table layout

* added markup structure / css for overview page

* add flyout and links to other pages

* add "alpha" messaging at bottom of all pages

* attrs instead of defaultProps on styled components

* use FormattedMessage on alpha messaging component

* remove leftover code

* remove unused import
Comment on lines +23 to +24
display: flex;
flex-direction: column;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the flex properties here, as well as in with_header and without_header layouts in #63992.

The flex properties were breaking other pages, causing them not to expand to full width. It didn't seem like the removal affected the overview page contents or the alpha messaging so hopefully it's good to go. For future reference if a page content needs flex, the individual pages should wrap its contents in EuiFlexGroup or similar. The base layouts will rarely need adjusting :)

gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 21, 2020
* master: (30 commits)
  Migrate vis_type_table to kibana/new platform  (elastic#63105)
  Enable include/exclude in Terms agg for numeric fields (elastic#59425)
  follow conventions for saved object definitions (elastic#63571)
  [Docs]Adds saved object key setting to load balancing kib instances (elastic#63935)
  kbn/config-schema: Consider maybe properties as optional keys in ObjectType (elastic#63838)
  Fix page layouts, clean up unused code (elastic#63992)
  [SIEM] Adds recursive exact key checks for validation and formatter
  [Maps] Migrate remaining maps client files to NP (except routi… (elastic#63859)
  [Maps] Do not fetch geo_shape from docvalues (elastic#63997)
  Vega doc changes (elastic#63889)
  [Metrics UI] Reorganize file layout for Metrics UI (elastic#60049)
  Add sub-menus to Resolver node (for 75% zoom) (elastic#63476)
  [FTR] Add test suite metrics tracking/output (elastic#62515)
  [ML] Fixing single metric viewer page padding (elastic#63839)
  [Discover] Allow user to generate a report after saving a modified saved search (elastic#63623)
  [Reporting] Config flag to escape formula CSV values (elastic#63645)
  [Metrics UI] Remove remaining field filtering (elastic#63398)
  [Maps] fix date labels (elastic#63909)
  [TSVB] Use default Kibana palette for split series (elastic#62241)
  Ingest overview page (elastic#63214)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 22, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 22, 2020
jen-huang pushed a commit that referenced this pull request Apr 22, 2020
* use fixed table layout

* added markup structure / css for overview page

* add flyout and links to other pages

* add "alpha" messaging at bottom of all pages

* attrs instead of defaultProps on styled components

* use FormattedMessage on alpha messaging component

* remove leftover code

* remove unused import

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingest Management:alpha1 Group issues for ingest management alpha1 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants