[NP] Migrate logstash server side code to NP #63135

mshustov · 2020-04-09T15:13:45Z

Summary

Part of #60937

adds a licensing route handler wrapper. can be used by plugins to implement license check as HOF
moves logstash routes to NP
keeps legacy license check in LP as the client code consumes it

Checklist

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-04-09T15:13:47Z

Pinging @elastic/kibana-platform (Team:Platform)

mshustov · 2020-04-09T15:30:06Z

I'm surprised there is no code-owner even for the LP part, so I tagged @ycombinator directly.

x-pack/plugins/logstash/server/models/cluster/cluster.test.ts

ycombinator · 2020-04-13T14:47:46Z

Hey @restrry, looks like some tests are still failing on this PR. Did you want to fix them first before I start reviewing or should I go ahead?

mshustov · 2020-04-13T15:17:13Z

@ycombinator as I can see, those failed tests aren't related to the changes. I'm going to take a look at them tomorrow when I'm back. It doesn't block a review I believe

pgayvallet · 2020-04-14T06:36:36Z

ack: will review today

mshustov · 2020-04-14T07:09:01Z

x-pack/plugins/security/common/licensing/license_service.test.ts

-            "showLinks": false,
-            "showLogin": false,
-            "showRoleMappingsManagement": false,
+            "allowLogin": true,


I added default values to the getFeature mock led to these changes.

azasypkin

Security changes LGTM.

x-pack/plugins/licensing/server/licensing_checker_route_handler_wrapper.test.ts

x-pack/plugins/licensing/server/license_checker_route_handler_wrapper.ts

x-pack/plugins/licensing/server/licensing_checker_route_handler_wrapper.test.ts

x-pack/plugins/logstash/server/types.ts

x-pack/plugins/logstash/server/routes/upgrade/execute.ts

x-pack/plugins/logstash/server/models/cluster/cluster.ts

x-pack/plugins/logstash/server/plugin.ts

x-pack/plugins/logstash/server/routes/cluster/load.ts

x-pack/plugins/logstash/server/routes/index.ts

x-pack/plugins/logstash/server/routes/pipeline/save.ts

ycombinator · 2020-04-14T10:40:38Z

I've tested the basic functionality of the Logstash Central Management UI with this PR and compared it with running master. The basic functionality continues to work as expected with this PR 👍.

I'm now going to test the slightly more advanced setup that requires the Logstash Central Management UI reading data from the Stack Monitoring plugin.

ycombinator

I've tested the slightly more advanced setup where the Logstash Central Management plugin reads data from the Stack Monitoring plugin and it also works as expected 👍.

Functionally, this PR LGTM. Thanks for migrating this plugin to NP, @restrry!

pgayvallet

LGTM

kibanamachine · 2020-04-14T15:34:31Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8344876

History

💛 Build #40579 was flaky 1d85d54
💔 Build #39963 failed 871b3d7
💔 Build #39943 failed b40ef71
💔 Build #39903 failed fa5fe8b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* convert api_integration test into TS * create logstash NP plugin and move models * move common/constants to NP * type fetch all from scroll * move route declaration to NP * add licence checker wrapper * register logstash route handlers in NP * track logstash NP i18n * address shaunak comment * fix validation * udpdate security tests since for new mock defaults * address Pierres comments * rename upgrade file route

* master: (29 commits) Add test:jest_integration npm script (elastic#62938) [data.search.aggs] Remove service getters from agg types (AggConfig part) (elastic#62548) [Discover] Fix broken setting of bucketInterval (elastic#62939) Disable adding conditions when in alert management context. (elastic#63514) [Alerting] fixes to allow pre-configured actions to be executed (elastic#63432) adding useMemo (elastic#63504) [Maps] fix double fetch when filter pill is added (elastic#63024) [Lens] Fix missing formatting bug in "break down by" (elastic#63288) [SIEM] [Cases] Removed double pasted line (elastic#63507) [Reporting] Improve functional test steps (elastic#63259) [SIEM][CASE] Tests for server's configuration API (elastic#63099) [SIEM] [Cases] Case container unit tests (elastic#63376) [ML] Improving parsing of large uploaded files (elastic#62970) [ML] Listing global calendars on the job management page (elastic#63124) [Ingest][Endpoint] Add Ingest rest api response types for use in Endpoint (elastic#63373) Add help text to form fields (elastic#63165) [ML] Converts utils Mocha tests to Jest (elastic#63132) [Metrics UI] Refactor With* containers to hooks (elastic#59503) [NP] Migrate logstash server side code to NP (elastic#63135) Clicking cancel in saved query save modal doesn't close it (elastic#62774) ...

* alerting/alert-services-mock: (107 commits) removed unused import added alert services mock and use it in siem [Metrics UI] Refactor With* containers to hooks (elastic#59503) [NP] Migrate logstash server side code to NP (elastic#63135) Clicking cancel in saved query save modal doesn't close it (elastic#62774) [Lens] Migration from 7.7 (elastic#62879) [Lens] Fix bug where suggestions didn't use filters (elastic#63293) Task/linux events (elastic#63400) [Remote clusters] guard against usageCollection plugin if unav… (elastic#63284) [Uptime] Remove pings graphql (elastic#59392) Index Pattern Field class - factor out copy_field code for future typescripting (elastic#63083) [EPM] add/remove package in package settings page (elastic#63389) Adjust API authorization logging (elastic#63350) Revert FTR: add chromium-based Edge browser support (elastic#61684) (elastic#63448) [Event Log] Adds namespace into save objects (elastic#62974) document code splitting for client code (elastic#62593) Escape single quotes surrounded by double quotes (elastic#63229) [Endpoint] Update cli mapping to match endpoint package (elastic#63372) update in-app links to metricbeat configuration docs (elastic#63295) investigation notes field (documentation / metadata) (elastic#63386) ...

* convert api_integration test into TS * create logstash NP plugin and move models * move common/constants to NP * type fetch all from scroll * move route declaration to NP * add licence checker wrapper * register logstash route handlers in NP * track logstash NP i18n * address shaunak comment * fix validation * udpdate security tests since for new mock defaults * address Pierres comments * rename upgrade file route

mshustov added 7 commits April 9, 2020 10:36

convert api_integration test into TS

9432ada

create logstash NP plugin and move models

f6c9f01

move common/constants to NP

b8e114e

type fetch all from scroll

fcca07d

move route declaration to NP

877fa0f

add licence checker wrapper

f3385ee

register logstash route handlers in NP

fa5fe8b

mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration v7.8.0 labels Apr 9, 2020

mshustov requested review from ycombinator and a team April 9, 2020 15:14

joshdover mentioned this pull request Apr 9, 2020

Migrate Logstash plugin #60937

Closed

7 tasks

ycombinator reviewed Apr 9, 2020

View reviewed changes

x-pack/plugins/logstash/server/models/cluster/cluster.test.ts Outdated Show resolved Hide resolved

mshustov added 4 commits April 9, 2020 18:35

track logstash NP i18n

b703771

Merge branch 'master' into issue-60937-logstash-server

7cd1475

address shaunak comment

b40ef71

fix validation

871b3d7

mshustov marked this pull request as ready for review April 9, 2020 19:26

mshustov added 2 commits April 14, 2020 08:42

Merge branch 'master' into issue-60937-logstash-server

f65fa3a

udpdate security tests since for new mock defaults

1d85d54

mshustov requested a review from a team as a code owner April 14, 2020 07:05

mshustov commented Apr 14, 2020

View reviewed changes

azasypkin approved these changes Apr 14, 2020

View reviewed changes

pgayvallet reviewed Apr 14, 2020

View reviewed changes

ycombinator approved these changes Apr 14, 2020

View reviewed changes

mshustov added 3 commits April 14, 2020 14:21

Merge branch 'master' into issue-60937-logstash-server

8d36307

address Pierres comments

de1a537

rename upgrade file route

8344876

pgayvallet approved these changes Apr 14, 2020

View reviewed changes

mshustov merged commit d015c24 into elastic:master Apr 14, 2020

mshustov deleted the issue-60937-logstash-server branch April 14, 2020 15:45

mshustov mentioned this pull request Apr 14, 2020

[7.x] [NP] Migrate logstash server side code to NP (#63135) #63477

Merged

mshustov mentioned this pull request Sep 3, 2020

Cannot create logstash pipeline due to broken validation #76611

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NP] Migrate logstash server side code to NP #63135

[NP] Migrate logstash server side code to NP #63135

mshustov commented Apr 9, 2020 •

edited

Loading

elasticmachine commented Apr 9, 2020

mshustov commented Apr 9, 2020 •

edited

Loading

ycombinator commented Apr 13, 2020

mshustov commented Apr 13, 2020 •

edited

Loading

pgayvallet commented Apr 14, 2020

mshustov Apr 14, 2020

azasypkin left a comment

ycombinator commented Apr 14, 2020

ycombinator left a comment

pgayvallet left a comment

kibanamachine commented Apr 14, 2020

[NP] Migrate logstash server side code to NP #63135

[NP] Migrate logstash server side code to NP #63135

Conversation

mshustov commented Apr 9, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Apr 9, 2020

mshustov commented Apr 9, 2020 • edited Loading

ycombinator commented Apr 13, 2020

mshustov commented Apr 13, 2020 • edited Loading

pgayvallet commented Apr 14, 2020

mshustov Apr 14, 2020

Choose a reason for hiding this comment

azasypkin left a comment

Choose a reason for hiding this comment

ycombinator commented Apr 14, 2020

ycombinator left a comment

Choose a reason for hiding this comment

pgayvallet left a comment

Choose a reason for hiding this comment

kibanamachine commented Apr 14, 2020

💚 Build Succeeded

History

mshustov commented Apr 9, 2020 •

edited

Loading

mshustov commented Apr 9, 2020 •

edited

Loading

mshustov commented Apr 13, 2020 •

edited

Loading