Give ui/courier/fetch a makeover #6307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the transition to es6 modules, provider names were calculated automatically based on the require path. When using relative paths this produces pretty nice names, but since the courier used absolute ids the import names were pretty messy.
|
Tests failed |
|
jenkins, test it |
|
This seems to have legitimate test failures. |
|
Test failures, in case you missed them |
|
We could still get this into 4.5 if you want. |
| @@ -1,8 +1,10 @@ | |||
| import _ from 'lodash'; | |||
| // import _ from 'lodash'; | |||
There was a problem hiding this comment.
Can we just remove this rather than comment it out?
|
LGTM |
|
jenkins, test it |
spalger
added a commit
that referenced
this pull request
Mar 8, 2016
Give ui/courier/fetch a makeover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spruced up the code in the ui/courier/fetch module. These could be separate PRs, happy to split them up, but use commits to split up the work instead.
_prefix from file names.CourierDataSourceDocSourceProvider)var->letandconst_.class()->class {}