Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Chrome tabs to the new design #6301

Merged
merged 1 commit into from
Feb 25, 2016

Conversation

panda01
Copy link
Contributor

@panda01 panda01 commented Feb 22, 2016

A partial revert of #6198.
Put back the Chrome tabs so other apps can have a sub nav.
removed the Kibana App tabs.

@tsullivan
Copy link
Member

image

@panda01 panda01 force-pushed the feature/chrome-tabs branch from fd43252 to 154f9ab Compare February 22, 2016 20:18
@tsullivan
Copy link
Member

LGTM

@panda01 panda01 assigned jbudz and unassigned tsullivan Feb 22, 2016
@jbudz
Copy link
Member

jbudz commented Feb 25, 2016

image

The settings page tab points to /undefined and has an underline on hover

> li > a {
color: @kibanaGray2;
font-size: 1.5em;
padding-top: 5px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can these use the padding shorthand?

@jbudz jbudz assigned panda01 and unassigned jbudz Feb 25, 2016
@panda01 panda01 force-pushed the feature/chrome-tabs branch from 154f9ab to 4f365b5 Compare February 25, 2016 15:05
@panda01
Copy link
Contributor Author

panda01 commented Feb 25, 2016

@jbudz Addressed your concerns, passing back.

@panda01 panda01 assigned jbudz and unassigned panda01 Feb 25, 2016
@jbudz
Copy link
Member

jbudz commented Feb 25, 2016

LGTM

@jbudz jbudz assigned panda01 and unassigned jbudz Feb 25, 2016
panda01 added a commit that referenced this pull request Feb 25, 2016
Updated Chrome tabs to the new design
@panda01 panda01 merged commit 59169b8 into elastic:feature/design Feb 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants