Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] [7.7] Migration for 7.7 #62877

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Conversation

wylieconlon
Copy link
Contributor

@wylieconlon wylieconlon commented Apr 7, 2020

When loading a saved XY Lens visualization that was created pre-7.7, such as bar chart, line chart, or area chart, the configuration panel on the right would show empty dimensions like this:

Screenshot 2020-04-03 18 22 48

The bug was caused by a change to how dimensions are represented that I introduced in #58279

Instead of fixing the bug in the runtime, this is fixing the bug using a migration. After 7.7 was branched from master, @timroes changed the way Lens saved objects were registered, so this PR can only target 7.7- another PR will target 7.8 and later

Fixes #61939

Replaces #62707

Checklist

@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.7.0 labels Apr 7, 2020
@wylieconlon wylieconlon requested review from timroes and mbondyra April 7, 2020 22:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra
Copy link
Contributor

mbondyra commented Apr 8, 2020

I've tested the following configurations on Chrome, migrating from 7.6:

  1. Single layer
    a. Date histogram on count
    b. Date histogram with multiple y axes and break down applied
    c. non-time X-axis and single Y axis
    d. non-time X-axis and multiple y axes and break down applied
  2. Multiple layers
    a. two layers both of one date histogram of the same primary timefield on one index
    b. two layers of different X axes (time based and not time based) and multiple Y-axes
    c. two time-based visualizations on different index patterns

All works as expected migrating from 7.6 to this PR. 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants