Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alerting UI flaky tests #62817

Merged
merged 13 commits into from
Apr 15, 2020
Merged

Fix alerting UI flaky tests #62817

merged 13 commits into from
Apr 15, 2020

Conversation

mikecote
Copy link
Contributor

@mikecote mikecote commented Apr 7, 2020 •
edited
Loading

Resolves #62472
Resolves #62494

In this PR, I'm fixing flakiness within the alerts functional tests. It seems the alert form component renders about 3 times when invoking the flyout (I believe: initial render, setDefaultActionGroupId, setAlertTypesIndex). Because the clearValue() function doesn't trigger a change event, the textbox would get re-populated if ever a render happened right after. Using clearWithKeyboard causes change events to be triggered and the state to include the cleared value.

I'm also changing some code to simply use testSubjects.setValue to keep things simple and to use a common function used by others.

Latest 42x run: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/363/
Latest 42x run for Uptime: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/362/

@mikecote mikecote added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.8.0 labels Apr 7, 2020
@mikecote mikecote self-assigned this Apr 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@chandlerprall chandlerprall mentioned this pull request Apr 8, 2020
Closed
@mikecote
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@mikecote mikecote mentioned this pull request Apr 14, 2020
Closed
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mikecote mikecote marked this pull request as ready for review April 14, 2020 19:42
@mikecote mikecote requested a review from a team as a code owner April 14, 2020 19:42
YulNaumenko
YulNaumenko approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pmuellr
pmuellr approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mikecote added a commit to mikecote/kibana that referenced this pull request Apr 15, 2020
@mikecote
Fix alerting UI flaky tests (elastic#62817)
9227ee0 
* Use of testSubjects.setValue

* Add waitForEditAlertFlyout

* Fix some extra flakiness

* Test half second sleep to confirm cause of flakiness

* Revert 0241796

* Try clearWithKeyboard

* Fix test failures

* Fix uptime tests

* Revert uptime changes
@mikecote mikecote mentioned this pull request Apr 15, 2020
Merged
mikecote added a commit to mikecote/kibana that referenced this pull request Apr 15, 2020
@mikecote
Fix alerting UI flaky tests (elastic#62817)
fd9d5c7 
* Use of testSubjects.setValue

* Add waitForEditAlertFlyout

* Fix some extra flakiness

* Test half second sleep to confirm cause of flakiness

* Revert 0241796

* Try clearWithKeyboard

* Fix test failures

* Fix uptime tests

* Revert uptime changes
@mikecote mikecote mentioned this pull request Apr 15, 2020
Merged
wayneseymour pushed a commit that referenced this pull request Apr 15, 2020
@mikecote @wayneseymour
Fix alerting UI flaky tests (#62817)
4f903ee 
* Use of testSubjects.setValue

* Add waitForEditAlertFlyout

* Fix some extra flakiness

* Test half second sleep to confirm cause of flakiness

* Revert 0241796

* Try clearWithKeyboard

* Fix test failures

* Fix uptime tests

* Revert uptime changes
mikecote added a commit that referenced this pull request Apr 15, 2020
@mikecote
Fix alerting UI flaky tests (#62817) (#63612)
d9b1ff8 
* Use of testSubjects.setValue

* Add waitForEditAlertFlyout

* Fix some extra flakiness

* Test half second sleep to confirm cause of flakiness

* Revert 0241796

* Try clearWithKeyboard

* Fix test failures

* Fix uptime tests

* Revert uptime changes
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 16, 2020
@mikecote
Copy link
Contributor Author

Note: Holding off merging into 7.7 until the branch is upgraded to 7.7.1

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

18 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

mikecote added a commit that referenced this pull request May 14, 2020
@mikecote @elasticmachine
Fix alerting UI flaky tests (#62817) (#63615)
9d1274a 
* Use of testSubjects.setValue

* Add waitForEditAlertFlyout

* Fix some extra flakiness

* Test half second sleep to confirm cause of flakiness

* Revert 0241796

* Try clearWithKeyboard

* Fix test failures

* Fix uptime tests

* Revert uptime changes

Co-authored-by: Elastic Machine <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@pmuellr pmuellr pmuellr approved these changes

Assignees

@mikecote mikecote

Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.1 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@mikecote @elasticmachine @kibanamachine @pmuellr @YulNaumenko