[cli/server] preserve plugins.paths set in yml config
#6259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't suppose we're lucky enough to have tests for this file? LGTM |
|
Unfortunately we don't, but I will write them after elasticon. See #6261 |
spalger
added a commit
that referenced
this pull request
Feb 16, 2016
[cli/server] preserve `plugins.paths` set in yml config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a config file defines
plugins.pathsthe paths are overwritten when the serve task merges in the--plugin-pathflags.This same change set was applied to
plugins.scanDirsat some point, but never got applied toplugins.paths.