Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI Alerting] Bootstrap with skeleton of alert typedef and frontend type #62496

Closed
wants to merge 3 commits into from

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Apr 3, 2020

Closes #61871

This provides a framework to build the new logs alert type.

Frontend is currently non-functional, but manually sending API requests to the methods in https://github.com/elastic/kibana/blob/master/x-pack/plugins/alerting/README.md should work for the backend.

@Zacqary Zacqary added Feature:Alerting Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Apr 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Kerry350 Kerry350 self-requested a review April 6, 2020 11:17
@Kerry350
Copy link
Contributor

Kerry350 commented Apr 6, 2020

Ace, thanks for adding this 👌👍

Are you okay fixing the minor build failures?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary
Copy link
Contributor Author

Zacqary commented Apr 6, 2020

@Kerry350 Build issues all fixed now!

Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zacqary Great, thank you! And thanks for the comments throughout.

@Zacqary
Copy link
Contributor Author

Zacqary commented Apr 7, 2020

This branch serves as the base of #62806 so I'm closing it

@Zacqary Zacqary closed this Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Logs UI Alerting] Bootstrap
4 participants