Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Retrieving persisted note once it is created #62444

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Apr 3, 2020

Summary

https://github.com/elastic/siem-team/issues/585
Before: The result of getAllTimelines after importing timeline came back without notes
Screenshot 2020-04-03 at 12 56 11

After: Notes can be fetched correctly
save_timeline

To verify this PR:

  1. Go to Timelines
  2. Create a timeline with more than one note and a query and mark it as favourite
  3. Export the created timeline
  4. Delete the created timeline
  5. Import the exported timeline
  6. Check if there is an arrow at the left hand side of the timeline's name

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@angorayc angorayc added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Apr 3, 2020
@angorayc angorayc requested a review from a team as a code owner April 3, 2020 13:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I test it locally and I see my two notes and the arrow at the left of the timeline's name. I also verified that the JSON contains the two notes.

@angorayc angorayc merged commit f7bbf33 into elastic:master Apr 3, 2020
angorayc added a commit to angorayc/kibana that referenced this pull request Apr 3, 2020
angorayc added a commit to angorayc/kibana that referenced this pull request Apr 3, 2020
@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

angorayc added a commit that referenced this pull request Apr 4, 2020
angorayc added a commit that referenced this pull request Apr 4, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants