[NP] Visualize #62294

sulemanof · 2020-04-02T11:09:11Z

Summary

Move the Visualize plugin into new platform.

The changes are:

set kibana-app as codeowner;
create visualize namespace for translations, fix translations;
wrap Timelion options into KibanaContextProvider (before dependencies were passed through the default editor context, but when moved into NP this appeared in a separate bundle and become unavailable);
disabled Share button in top nav when share plugin is turned off (the same was done in dashboard);
visualizations plugin includes @import 'components/index' in src/plugins/visualizations/public/index.scss to be consumed by other plugins, but have to left over the import here : https://github.com/elastic/kibana/pull/62294/files#diff-bc1ed535c452a3c114f6622450f0bf1e for passing karma browser tests,
so they are currently included twice temporarily, but it shouldn't be a problem

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

# Conflicts: # src/legacy/core_plugins/kibana/index.js # src/legacy/core_plugins/kibana/public/kibana.js # src/legacy/core_plugins/kibana/public/visualize/_index.scss # src/legacy/core_plugins/kibana/public/visualize/legacy_imports.ts # src/plugins/dashboard/public/index.ts # src/plugins/vis_default_editor/public/default_editor.tsx # src/plugins/vis_default_editor/public/default_editor_controller.tsx # src/plugins/visualize/public/kibana_services.ts # src/plugins/visualize/public/plugin.ts

elasticmachine · 2020-04-08T14:45:13Z

Pinging @elastic/kibana-app (Team:KibanaApp)

flash1293

Tested in Chrome and couldn't find any problems - LGTM 🎉

flash1293 · 2020-04-09T13:47:44Z

src/plugins/visualize/public/plugin.ts

@@ -27,64 +27,45 @@ import {
  CoreStart,
  Plugin,
  PluginInitializerContext,
-  SavedObjectsClientContract,


Thanks for cleaning up the plugin class as well! Long overdue.

sulemanof · 2020-04-10T07:50:36Z

@elasticmachine merge upstream

sulemanof · 2020-04-13T07:20:48Z

@elasticmachine merge upstream

flash1293

Tested in Chrome and LGTM, I left one comment about the embeddable dependency.

flash1293 · 2020-04-14T12:52:53Z

src/plugins/visualize/kibana.json

+  "ui": true,
+  "requiredPlugins": [
+    "data",
+    "embeddable",


I didn't think of this initially, but @timroes is making a good point about this dependency in the Lens PR: #62965

As visualize works just fine without embeddables, this should be an optional dependency and usages should be wrapped into an if() { block similar to share and home

A funny thing, this showed up Visualize doesn't need the embeddable dependency at all. Seems it's just a useless left over.
So I just removed it in one of the last commit. Thanks for this catch!

…sualize

# Conflicts: # .github/CODEOWNERS

elizabetdev

LGTM! 🎉

# Conflicts: # src/plugins/visualize/public/application/editor/editor.js # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

kibanamachine · 2020-04-16T15:12:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 3edbc08

History

💚 Build #41168 succeeded 99c6607
💚 Build #40880 succeeded ceff449
💚 Build #40338 succeeded 941d82a
💚 Build #40092 succeeded 004e312
💔 Build #39866 failed 00f29d8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Move visualize plugin to np * Refactor plugin services * Clean up * Remove legacy style usage * Fix style imports * Fix timelion_options context provider * Fix translations * Change codeowners for visualize * Import styles in legacy for BWC in Browser tests * Get rid of embeddable dependency Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # .github/CODEOWNERS # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

sulemanof added 4 commits April 2, 2020 11:49

Move visualize plugin to np

ae8c4df

Refactor plugin services

2ce021c

Merge remote-tracking branch 'upstream/master' into np/visualize

b36a750

Clean up

2a5e63f

flash1293 mentioned this pull request Apr 2, 2020

Meta: Kibana app NP cutover #60097

Closed

69 tasks

sulemanof added 6 commits April 8, 2020 12:34

Remove legacy style usage

325de83

Fix style imports

dbd1946

Fix timelion_options context provider

aa27888

Fix translations

a7edd02

Change codeowners for visualize

38c8d67

sulemanof added Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0 v8.0.0 labels Apr 8, 2020

sulemanof added 2 commits April 9, 2020 13:04

Import styles in legacy for BWC in Browser tests

4daf88c

Merge remote-tracking branch 'upstream/master' into np/visualize

d1b51a0

sulemanof marked this pull request as ready for review April 9, 2020 10:13

sulemanof requested a review from a team April 9, 2020 10:13

sulemanof requested a review from a team as a code owner April 9, 2020 10:13

Merge remote-tracking branch 'upstream/master' into np/visualize

00f29d8

flash1293 approved these changes Apr 9, 2020

View reviewed changes

Merge branch 'master' into np/visualize

004e312

Merge branch 'master' into np/visualize

941d82a

flash1293 approved these changes Apr 14, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into np/visualize

bdb058e

sulemanof added 3 commits April 15, 2020 11:29

Get rid of embeddable dependency

381c1c6

Merge branch 'np/visualize' of github.com:sulemanof/kibana into np/vi…

ceff449

…sualize

Merge remote-tracking branch 'upstream/master' into np/visualize

99c6607

# Conflicts: # .github/CODEOWNERS

elizabetdev approved these changes Apr 16, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into np/visualize

3edbc08

# Conflicts: # src/plugins/visualize/public/application/editor/editor.js # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

sulemanof merged commit 6bbcabc into elastic:master Apr 16, 2020

sulemanof deleted the np/visualize branch April 16, 2020 15:32

sulemanof mentioned this pull request Apr 17, 2020

[7.x] [NP] Visualize (#62294) #63822

Closed

sulemanof mentioned this pull request Apr 17, 2020

[7.x] [NP] Visualize (#62294) #63833

Merged

sulemanof added the backported label Apr 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NP] Visualize #62294

[NP] Visualize #62294

sulemanof commented Apr 2, 2020 •

edited

Loading

elasticmachine commented Apr 8, 2020

flash1293 left a comment

flash1293 Apr 9, 2020

sulemanof commented Apr 10, 2020

sulemanof commented Apr 13, 2020

flash1293 left a comment

flash1293 Apr 14, 2020

sulemanof Apr 15, 2020

elizabetdev left a comment

kibanamachine commented Apr 16, 2020

[NP] Visualize #62294

[NP] Visualize #62294

Conversation

sulemanof commented Apr 2, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Apr 8, 2020

flash1293 left a comment

Choose a reason for hiding this comment

flash1293 Apr 9, 2020

Choose a reason for hiding this comment

sulemanof commented Apr 10, 2020

sulemanof commented Apr 13, 2020

flash1293 left a comment

Choose a reason for hiding this comment

flash1293 Apr 14, 2020

Choose a reason for hiding this comment

sulemanof Apr 15, 2020

Choose a reason for hiding this comment

elizabetdev left a comment

Choose a reason for hiding this comment

kibanamachine commented Apr 16, 2020

💚 Build Succeeded

History

sulemanof commented Apr 2, 2020 •

edited

Loading