Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5 dashboard restyle #6214

Merged
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions FAQ.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
**A:** Kibana 4 packages are architecture specific. Ensure you are using the correct package for your architecture.

**Q:** Where do I go for support?
**A:** Please join us at [discuss.elastic.co](discuss.elastic.co) with questions. Your problem might be a bug, but it might just be a misunderstanding, or feature we could improve. We're also available on Freenode in #kibana
**A:** Please join us at [discuss.elastic.co](https://discuss.elastic.co) with questions. Your problem might be a bug, but it might just be a misunderstanding, or feature we could improve. We're also available on Freenode in #kibana
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comes from master. Minor, but there.


**Q:** Ok, we talked about it and its definitely a bug
**A:** Doh, ok, let's get that fixed. File an issue on [github.com/elastic/kibana](github.com/elastic/kibana). I'd recommend reading the beginning of the CONTRIBUTING.md, just so you know how we'll handle the issue.
**A:** Doh, ok, let's get that fixed. File an issue on [github.com/elastic/kibana](https://github.com/elastic/kibana). I'd recommend reading the beginning of the CONTRIBUTING.md, just so you know how we'll handle the issue.

### Kibana 3 Migration
**Q:** Where is feature X that I loved from Kibana 3?
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
<div class="panel panel-default" ng-switch on="panel.type" ng-if="savedObj || error">
<div class="panel-heading">
<span class="panel-title" title="{{::savedObj.title}}">
<i
class="fa"
ng-class="savedObj.vis.type.icon"
aria-label="{{::savedObj.vis.type.title}} Icon"
title="{{::savedObj.vis.type.title}}">
</i>
{{::savedObj.title}}
</span>
<div class="btn-group">
Expand Down
32 changes: 31 additions & 1 deletion src/plugins/kibana/public/dashboard/styles/main.less
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,24 @@ dashboard-grid {
width: 25px;
}

.gs-w {
border: 2px dashed transparent;

&:hover {
border-color: @kibanaGray4;

dashboard-panel {
.visualize-show-spy {
visibility: visible;
}
.panel .panel-heading .btn-group {
display: block !important;
}
}

}
}

i.remove {
cursor: pointer;
}
Expand All @@ -58,15 +76,23 @@ dashboard-grid {
display: flex;
flex-direction: column;
justify-content: flex-start;
border: 0 solid transparent;

.panel-heading {
padding: 0px 0px 5px 5px;
flex: 0 0 auto;
white-space: nowrap;
display: flex;
border-top-right-radius: 0;
border-top-left-radius: 0;
background-color: @white;
border: none;

div.btn-group {
.btn-group {
a {
color: inherit;
}
display: none;
white-space: nowrap;
flex: 0 0 auto;
}
Expand Down Expand Up @@ -99,6 +125,10 @@ dashboard-grid {
}
}

.visualize-show-spy {
visibility: hidden;
}

.load-error {
text-align: center;
font-size: 1em;
Expand Down
2 changes: 1 addition & 1 deletion src/ui/public/styles/base.less
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ html,
body {
.flex-parent();
height: 100%;
margin: 0px;
margin: 0;
}

label > small {
Expand Down
4 changes: 2 additions & 2 deletions src/ui/public/styles/variables/for-theme.less
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@


// Dashboard ===================================================================
@dashboard-bg: @gray-lighter;
@dashboard-panel-bg: @panel-bg;
@dashboard-bg: #fff;
@dashboard-panel-bg: #fff;
@dashboard-panel-color: @text-color;
@dashboard-panel-heading-link-color: @text-color;
@dashboard-panel-heading-link-hover-color: @link-hover-color;
Expand Down