Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Use indices options in datafeed preview #61698

Merged
merged 1 commit into from
Mar 30, 2020
Merged

[ML] Use indices options in datafeed preview #61698

merged 1 commit into from
Mar 30, 2020

Conversation

jgowdyelastic
Copy link
Member

If the datafeed contains an indices_options section, the contained settings should be used in the datafeed preview search.

Fixes #61664

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience non-issue Indicates to automation that a pull request should not appear in the release notes :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 27, 2020
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner March 27, 2020 20:15
@jgowdyelastic jgowdyelastic self-assigned this Mar 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic
Copy link
Member Author

This is a pain to test. I had modify the datafeed editor to allow me to change the datafeed's index so i could put in a non-exiting index.
I could then use

"indices_options": {
  "ignore_unavailable": true
}

to test that the search response wasn't an error.
I couldn't figure out any easier ways of testing the settings were affecting the preview search.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

walterra
walterra approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit 2c15087 into elastic:master Mar 30, 2020
@jgowdyelastic jgowdyelastic deleted the use-indices-options-in-datafeed-preview branch March 30, 2020 11:06
@jgowdyelastic jgowdyelastic mentioned this pull request Mar 30, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Mar 30, 2020
@jgowdyelastic
[ML] Use indices options in datafeed preview (elastic#61698)
a5beab2
@jgowdyelastic jgowdyelastic mentioned this pull request Mar 30, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Mar 30, 2020
@jgowdyelastic
[ML] Use indices options in datafeed preview (elastic#61698)
4d1c914
jgowdyelastic added a commit that referenced this pull request Mar 30, 2020
@jgowdyelastic
[ML] Use indices options in datafeed preview (#61698) (#61779)
46f4b80
jgowdyelastic added a commit that referenced this pull request Mar 30, 2020
@jgowdyelastic
[ML] Use indices options in datafeed preview (#61698) (#61778)
e2e3a2a
@jgowdyelastic jgowdyelastic mentioned this pull request Mar 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra walterra approved these changes

@darnautov darnautov Awaiting requested review from darnautov

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

@droberts195 droberts195 Awaiting requested review from droberts195

Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Use datafeed indices options when doing preview search
5 participants
@jgowdyelastic @elasticmachine @kibanamachine @walterra @peteharverson