Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] [Cases] Fix comments and user #61642

Merged
merged 2 commits into from
Mar 27, 2020
Merged

[SIEM] [Cases] Fix comments and user #61642

merged 2 commits into from
Mar 27, 2020

Conversation

stephmilovic
Copy link
Contributor

Fix 2 bugs:

  1. Edit comment broke yesterday when we started passing caseData.version instead of comment.version in the user action tree component
  2. The user_action_item component had fullName as a string field when it could be undefined or null, causing users without fullName to see a blown up case view page

Fix 1 inconsistency:

  1. username is all lowercase everywhere but 2 files in user_actions in the UI where it was userName. lowercased it for consistency

@stephmilovic stephmilovic added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@stephmilovic stephmilovic marked this pull request as ready for review March 27, 2020 15:31
@stephmilovic stephmilovic requested a review from a team as a code owner March 27, 2020 15:31
XavierM
XavierM approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit bec4e33 into elastic:master Mar 27, 2020
@stephmilovic stephmilovic deleted the case-bug-fix branch March 27, 2020 17:25
@stephmilovic stephmilovic mentioned this pull request Mar 27, 2020
Merged
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Mar 27, 2020
@stephmilovic
[SIEM] [Cases] Fix comments and user (elastic#61642)
9a85cd1
This was referenced Mar 27, 2020
Closed
Merged
@cnasikas cnasikas linked an issue Mar 27, 2020 that may be closed by this pull request
[SIEM][CASE] Comments are not being updated #61616
Closed
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Mar 27, 2020
@stephmilovic
[SIEM] [Cases] Fix comments and user (elastic#61642)
e7e998f
@cnasikas cnasikas mentioned this pull request Mar 27, 2020
Closed
stephmilovic added a commit that referenced this pull request Mar 28, 2020
@stephmilovic
[SIEM] [Cases] Fix comments and user (#61642) (#61669)
2d02d23
stephmilovic added a commit that referenced this pull request Mar 28, 2020
@stephmilovic
[SIEM] [Cases] Fix comments and user (#61642) (#61668)
e973f7a
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SIEM][CASE] Comments are not being updated
5 participants
@stephmilovic @elasticmachine @kibanamachine @XavierM @MindyRS