-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Update ML flyout to add cancel button #61627
[Uptime] Update ML flyout to add cancel button #61627
Conversation
Pinging @elastic/uptime (Team:uptime) |
<EuiSpacer /> | ||
</EuiFlyoutBody> | ||
<EuiFlyoutFooter> | ||
<EuiFlexGroup justifyContent="spaceBetween" alignItems="flexEnd"> | ||
<EuiFlexItem grow={true}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<EuiFlexItem grow={true}> | |
<EuiFlexItem grow={false}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if i set this to false, create new button will take all the space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i need to remove alignItems="flexEnd"
<EuiSpacer /> | ||
</EuiFlyoutBody> | ||
<EuiFlyoutFooter> | ||
<EuiFlexGroup justifyContent="spaceBetween" alignItems="flexEnd"> | ||
<EuiFlexItem grow={true}> | ||
<EuiButtonEmpty | ||
style={{ width: 100 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure - why do we need to set the width?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was taking half width and hence was pusing cancel button to center, i think maybe i could have achieved this by using justifyContent to flexStart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me check an EUI example to achieve this best using EUI
@katrin-freihofner updated the code. Removed width. |
8a2e662
to
c9c2d54
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* update button * fix type * update snaps * update layout
* update button * fix type * update snaps * update layout
Summary
Fixes: #61584
Added a cancel button on ML flyout