Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Update ML flyout to add cancel button #61627

Merged
merged 6 commits into from
Mar 30, 2020

Conversation

shahzad31
Copy link
Contributor

Summary

Fixes: #61584
Added a cancel button on ML flyout
image

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0 v7.8 v8.0.0 labels Mar 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

<EuiSpacer />
</EuiFlyoutBody>
<EuiFlyoutFooter>
<EuiFlexGroup justifyContent="spaceBetween" alignItems="flexEnd">
<EuiFlexItem grow={true}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<EuiFlexItem grow={true}>
<EuiFlexItem grow={false}>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if i set this to false, create new button will take all the space.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need to remove alignItems="flexEnd"

<EuiSpacer />
</EuiFlyoutBody>
<EuiFlyoutFooter>
<EuiFlexGroup justifyContent="spaceBetween" alignItems="flexEnd">
<EuiFlexItem grow={true}>
<EuiButtonEmpty
style={{ width: 100 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure - why do we need to set the width?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was taking half width and hence was pusing cancel button to center, i think maybe i could have achieved this by using justifyContent to flexStart

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me check an EUI example to achieve this best using EUI

@shahzad31
Copy link
Contributor Author

@katrin-freihofner updated the code. Removed width.

@shahzad31 shahzad31 force-pushed the update-anomaly-detection-flyout branch from 8a2e662 to c9c2d54 Compare March 30, 2020 14:22
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@katrin-freihofner katrin-freihofner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit d1cf0ac into elastic:master Mar 30, 2020
@shahzad31 shahzad31 deleted the update-anomaly-detection-flyout branch March 30, 2020 17:28
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Mar 30, 2020
* update button

* fix type

* update snaps

* update layout
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Mar 30, 2020
* update button

* fix type

* update snaps

* update layout
shahzad31 added a commit that referenced this pull request Mar 31, 2020
* update button

* fix type

* update snaps

* update layout
shahzad31 added a commit that referenced this pull request Mar 31, 2020
* update button

* fix type

* update snaps

* update layout
@rayafratkina rayafratkina removed the v7.8 label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uptime anomaly detection UI] 'Cancel' button is missing
5 participants