Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SearchProfiler] Set the agg treeRoot value #61591

Merged

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Mar 27, 2020

Summary

Discovered while doing final regression testing - we just set the treeRoot value on the aggregation object as we do for the search object.

How to test

Open SearchProfiler and profile the following query:

{ "aggs": { "updated_at" : { "avg": { "field": "any" } } } }

The profile tree should render normally.

Additional Context

It is still not entirely clear how this issue was not run into before.

@jloleysens jloleysens added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Search Profiler v7.7.0 v7.8.0 labels Mar 27, 2020
@jloleysens jloleysens requested a review from sebelga March 27, 2020 10:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally and works as expected. Thanks for fixing this!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Profiler release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants