-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Node.js to version 12 #61587
Conversation
Pinging @elastic/kibana-app-arch (Team:AppArch) |
6880749
to
7b18da9
Compare
a8698ea
to
9b80d5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i18n changes look good. only a trival snapshot update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kibana Presentation changes LGTM! Thanks for explaining the Promise / ticks change that happened in Node 11.
Pinging @elastic/ingest-management (Team:Ingest Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ingest Management change LGTM
💔 Build Failed
Failed CI StepsMetrics [docs]Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
FYI: This PR was merged before CI was passing on purpose, knowing that there would be an issue with the TypeScript tests. This is being fixed in |
* master: [Security Solution][Detections] Adds framework for replacing API schemas (elastic#82462) [Enterprise Search] Share Loading component (elastic#83246) Consolidates Jest configuration files and scripts (elastic#82671) APM header changes (elastic#82870) [Security Solutions] Adds a default for indicator match custom query of *:* (elastic#81727) [Security Solution] Note 10k object paging limit on Endpoint list (elastic#82889) [packerCache] fix gulp usage, don't archive node_modules (elastic#83327) Upgrade Node.js to version 12 (elastic#61587) [Actions] Removing placeholders and updating validation messages on connector forms (elastic#82734) [Fleet] Rename ingest_manager_api_integration tests fleet_api_integration (elastic#83011) [DOCS] Updates Discover docs (elastic#82773) [ML] Data frame analytics: Adds map view (elastic#81666) enables actions scoped within the stack to register at Basic license (elastic#82931)
Depends on #80468This upgrades the Node.js runtime to a new major version.
For a complete list of changes in the Node.js runtime, see the Node.js CHANGELOG. For only the breaking changes, see the list of notable changes for v11 and v12 respectively.
Closes #47968
Closes #26379
Major changes to Node.js impacting this upgrade
Release note
Upgrades the major Node.js version used by and shipped with Kibana from v10 to v12. This includes support for TLSv1.3 and three new cipher suites: TLS_AES_256_GCM_SHA384, TLS_CHACHA20_POLY1305_SHA256, and TLS_AES_128_GCM_SHA256.