Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] [CASES] bug/clean up phase I #61354

Merged
merged 7 commits into from
Mar 27, 2020
Merged

[SIEM] [CASES] bug/clean up phase I #61354

merged 7 commits into from
Mar 27, 2020

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Mar 25, 2020

Summary

  • refresh button on case view data
  • improve the post comment api to return all comments
  • three dots, connect ServiceNow actions from case view menu
  • remove comments which have already been pushed to ServiceNow
  • refresh comments when content refreshes

@XavierM XavierM added bug Fixes for quality problems that affect the customer experience release_note:enhancement Team:SIEM v8.0.0 v7.7.0 labels Mar 25, 2020
@XavierM XavierM requested a review from stephmilovic March 25, 2020 20:52
@XavierM XavierM requested a review from a team as a code owner March 25, 2020 20:52
@XavierM XavierM self-assigned this Mar 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@XavierM XavierM requested a review from cnasikas March 25, 2020 21:44
@stephmilovic stephmilovic mentioned this pull request Mar 25, 2020
Closed
26 tasks
stephmilovic
stephmilovic reviewed Mar 26, 2020
View reviewed changes
x-pack/plugins/case/server/services/index.ts
version?: string;
}

interface PatchComment {
commentId: string;
updatedAttributes: Partial<CommentAttributes & PushedArgs>;
updatedAttributes: Partial<CommentAttributes>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pick instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can update any CommentAttributes or do i miss something?

stephmilovic
stephmilovic reviewed Mar 26, 2020
View reviewed changes
x-pack/legacy/plugins/siem/public/pages/case/components/all_cases/columns.tsx
[hasDataToPush, isLoading, theCase.externalService]
);
const handleRenderDataToPush = useCallback(() => {
const lastCaseUpdate = theCase.updatedAt != null ? new Date(theCase.updatedAt) : null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the same logic as in use_post_push_to_service.tsx. can we lift it into a util file?

Copy link
Contributor Author

@XavierM XavierM Mar 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not because one is using CaseUserActions and the other one is using the data in case from the attributes external service

@stephmilovic

This comment has been minimized.

Sign in to view
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stephmilovic
stephmilovic reviewed Mar 26, 2020
View reviewed changes
x-pack/plugins/case/server/routes/api/cases/post_case.test.ts
@@ -43,14 +42,35 @@ describe('POST cases', () => {
expect(response.payload.id).toEqual('mock-it');
expect(response.payload.created_by.username).toEqual('awesome');
});

it(`Error if you passing status for a new case`, async () => {
const request = httpServerMock.createKibanaRequest({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

stephmilovic
stephmilovic approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review ✅
endpoint testing ✅
manual testing ✅
unit testing ✅

LGTM, thanks @XavierM 🚀 🎸

@XavierM XavierM merged commit 327f5a0 into elastic:master Mar 27, 2020
@XavierM XavierM mentioned this pull request Mar 27, 2020
Merged
XavierM added a commit to XavierM/kibana that referenced this pull request Mar 27, 2020
@XavierM
[SIEM] [CASES] bug/clean up phase I (elastic#61354)
e6280d1 
* clean up comments + add update_by/update_at  case when comment are added/updated + return all comments

* add refresh button + get a better interaction between user + fix bug with pushed data + fix three dot on detail page

* fix i18m

* review I

* review II
@XavierM XavierM mentioned this pull request Mar 27, 2020
Merged
XavierM added a commit to XavierM/kibana that referenced this pull request Mar 27, 2020
@XavierM
[SIEM] [CASES] bug/clean up phase I (elastic#61354)
898c6b9 
* clean up comments + add update_by/update_at  case when comment are added/updated + return all comments

* add refresh button + get a better interaction between user + fix bug with pushed data + fix three dot on detail page

* fix i18m

* review I

* review II
XavierM added a commit that referenced this pull request Mar 27, 2020
@XavierM
[SIEM] [CASES] bug/clean up phase I (#61354) (#61559)
80c2aeb 
* clean up comments + add update_by/update_at  case when comment are added/updated + return all comments

* add refresh button + get a better interaction between user + fix bug with pushed data + fix three dot on detail page

* fix i18m

* review I

* review II
XavierM added a commit that referenced this pull request Mar 27, 2020
@XavierM
[SIEM] [CASES] bug/clean up phase I (#61354) (#61560)
accb3dd 
* clean up comments + add update_by/update_at  case when comment are added/updated + return all comments

* add refresh button + get a better interaction between user + fix bug with pushed data + fix three dot on detail page

* fix i18m

* review I

* review II
@XavierM XavierM deleted the cases-clean-up branch June 4, 2020 16:05
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephmilovic stephmilovic stephmilovic approved these changes

@cnasikas cnasikas Awaiting requested review from cnasikas

Assignees

@XavierM XavierM

Labels
bug Fixes for quality problems that affect the customer experience release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XavierM @elasticmachine @stephmilovic @kibanamachine @MindyRS