Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Set os-packages flag on jenkins #6114

Merged
merged 1 commit into from
Feb 4, 2016
Merged

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Feb 4, 2016

Currently on jenkins, snapshot packages are built using symlinks. When building packages we copy files instead of linking, but this was not being passed to https://github.com/elastic/kibana/blob/f97f7141e65ad79d3bded1d8c4be1a729c2e80e5/tasks/build/versionedLinks.js. Instead of passing an argument, we set the os-packages option at the start of the jenkins task.

This can be tested locally by running grunt build --os-packages and making sure build/kibana*are not symlinked.

@epixa
Copy link
Contributor

epixa commented Feb 4, 2016

I can't get this to run successfully on my machine. I tried both node 0.12.9 and 4.2.4, but near the end it fails with:

Running "_build:pleaseRun" task
 > pleaserun --install --no-install-actions --install-prefix /Users/Court/p/kibana/build/services/launchd --overwrite --user kibana --sysv-log-path /var/log/kibana/ -p launchd -v 10.9 /opt/kibana/bin/kibana
Warning: spawnSync pleaserun ENOENT Use --force to continue.

@jbudz
Copy link
Member Author

jbudz commented Feb 4, 2016

There are some dependencies listed in, https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#building-os-packages. pleaserun, fpm, rpmbuild, dpkg. Eventually automating these dependencies from an image or container would be ideal but not there yet. I have it going from a VM currently.

@epixa
Copy link
Contributor

epixa commented Feb 4, 2016

Ohhh, I understand. My bad!

@epixa
Copy link
Contributor

epixa commented Feb 4, 2016

LGTM

@epixa epixa assigned jbudz and unassigned epixa Feb 4, 2016
jbudz added a commit that referenced this pull request Feb 4, 2016
[build] Set os-packages flag on jenkins
@jbudz jbudz merged commit ad2f9b4 into elastic:master Feb 4, 2016
@jbudz jbudz removed the v4.4.1 label Feb 4, 2016
@elasticsearch-bot
Copy link

Jon Budzenski merged this into the following branches!

Branch Commits
4.x b276336

elasticsearch-bot pushed a commit that referenced this pull request Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants