Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[es6Modules] handle simple case #6072

Merged
merged 1 commit into from
Feb 2, 2016

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Feb 2, 2016

In an effort to move to es6 modules, this is the first wave of changes which moves to import in the simplest of cases.

@epixa
Copy link
Contributor

epixa commented Feb 2, 2016

screen shot 2016-02-02 at 5 05 49 pm

:(

@spalger
Copy link
Contributor Author

spalger commented Feb 2, 2016

haha, yeah

@epixa
Copy link
Contributor

epixa commented Feb 2, 2016

LGTM

@epixa epixa assigned spalger and unassigned epixa Feb 2, 2016
@spalger spalger assigned tsullivan and unassigned spalger Feb 2, 2016
@tsullivan
Copy link
Member

Let's just call out that the simple case means statements like this are not updated yet:

let Command = require('commander').Command;

@tsullivan
Copy link
Member

LGTM

tsullivan added a commit that referenced this pull request Feb 2, 2016
@tsullivan tsullivan merged commit d75fb95 into elastic:master Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants