Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics Alerts] Add functional and unit tests #60442

Merged
merged 5 commits into from
Mar 19, 2020
Merged

[Metrics Alerts] Add functional and unit tests #60442

merged 5 commits into from
Mar 19, 2020

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Mar 17, 2020 •
edited
Loading

Summary

Closes #59832

Adds tests for alerting logic (Jest), and for ES query validation (functional)

Known issue: The count aggregator test doesn't pass. Tracked in #60441 This PR also fixes #60441

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@Zacqary Zacqary added Feature:Alerting Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 17, 2020
@Zacqary Zacqary requested a review from a team March 17, 2020 20:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

Zacqary
Zacqary commented Mar 18, 2020
View reviewed changes
Copy link
Contributor Author

@Zacqary Zacqary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since a large chunk of register_metric_threshold_alert_type was moved to a new file and the diff isn't easy to read, I've pointed out which lines fix the count bug

phillipb
phillipb approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Zacqary
Copy link
Contributor Author

Zacqary commented Mar 19, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary Zacqary merged commit 431b06f into elastic:master Mar 19, 2020
@Zacqary Zacqary deleted the 59832-threshold-alert-tests branch March 19, 2020 19:12
@Zacqary Zacqary mentioned this pull request Mar 20, 2020
Merged
Zacqary added a commit to Zacqary/kibana that referenced this pull request Mar 20, 2020
@Zacqary @elasticmachine
[Metrics Alerts] Add functional and unit tests (elastic#60442)
8ffb5ff 
* Add tests for metric threshold alerts

* Fix count aggregator

* Remove redundant typedefs

Co-authored-by: Elastic Machine <[email protected]>
Zacqary added a commit that referenced this pull request Mar 20, 2020
@Zacqary @elasticmachine
[Metrics Alerts] Add functional and unit tests (#60442) (#60774)
e7a4d57 
* Add tests for metric threshold alerts

* Fix count aggregator

* Remove redundant typedefs

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipb phillipb phillipb approved these changes

Assignees
No one assigned
Labels
Feature:Alerting Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metrics Alerts] Fix count aggregator [Metrics Alert] Write Backend Tests
4 participants
@Zacqary @elasticmachine @kibanamachine @phillipb