[EPM] Packages list tabs #60167
Merged
[EPM] Packages list tabs #60167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jen-huang
added
v8.0.0
release_note:skip
|
Pinging @elastic/ingest-management (Feature:EPM) |
13 tasks
jfsiii
reviewed
Mar 16, 2020
| @@ -4,7 +4,7 @@ | |||
| * you may not use this file except in compliance with the Elastic License. | |||
| */ | |||
|
|
|||
| import { SavedObjectAttributes } from '../../../../../../src/core/public'; | |||
| import { SavedObjectAttributes } from 'kibana/public'; | |||
There was a problem hiding this comment.
We used relative paths because we thought those were preferred over special/magic ones. What's the guidance from Platform, @joshdover?
There was a problem hiding this comment.
I confirmed with Platform that we prefer src/core/... imports over the magic kibana/... paths for importing types. Relative imports ../../../src/core... are only needed when importing concrete classes/functions. As we used kibana/ in many places even before this PR, I pushed up a change to replace all type imports from src/core/
...lugins/ingest_manager/public/applications/ingest_manager/sections/epm/screens/home/hooks.tsx
Show resolved
Hide resolved
nchaulet
reviewed
Mar 16, 2020
| {searchBar} | ||
| <EuiSpacer size="m" /> | ||
| {body} | ||
| {tabId === 'installed' ? <InstalledPackages /> : <AvailablePackages />} |
There was a problem hiding this comment.
@jen-huang can we use react-router sub routing here instead of a custom one, we can have a proper 404 handling if user type a wrong tab, @paul-tavares did this for the agent config detail tabs
nchaulet
approved these changes
Mar 16, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jen-huang
added a commit
that referenced
this pull request
Mar 17, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 17, 2020
* master: (30 commits) [TSVB] fix text color when using custom background color (elastic#60261) Fix import to timefilter from in TSVB (elastic#60296) [NP] Get rid of usage redirectWhenMissing service (elastic#59777) [SIEM] Fix Timeline footer styling (elastic#59587) [ML] Fixes to error handling for analytics jobs and file data viz (elastic#60249) Give better stack traces for Unhandled Promise Rejection warnings (elastic#60235) resolves elastic#58905 (elastic#60120) Added variables button for text fields in Pagerduty component. (elastic#60189) adds test that action vars are rendered for alert action parms (elastic#60310) Closes 59786 by removing the update toast (elastic#60172) [EPM] Packages list tabs (elastic#60167) Added message variables button for Webhook body form field (elastic#60174) Revert "adds new test (elastic#60064)" [Maps] move MapSavedObject type out of telemetry (elastic#60127) [Reporting] Fix error handling for job handler in route (elastic#60161) [Endpoint] TEST: verify alerts page header says 'Alerts' (elastic#60206) EMT-248: implement ack resource to accept event payload to acknowledge agent actions (elastic#60218) Migrate dual validated range (elastic#59689) Embeddable triggers (elastic#58440) [Endpoint] Sample data generator CLI script (elastic#59952) ...
jen-huang
added
the
Team:Fleet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #59826
Summary
This PR:
memoto fix flickering EPM headersrc/core/publicandsrc/core/server(instead of relative imports or magickibana/..paths)Screenshots
Gif showing loading states, non-flickering: