Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSS logic added to test environment #60134

Merged
merged 2 commits into from
Mar 13, 2020

Conversation

rashmivkulkarni
Copy link
Contributor

Summary

This is a pre-req PR for #52431.

Here I have added the logic for handling the tests with a boolean flag indicating if they are OSS or not.

@rashmivkulkarni rashmivkulkarni added enhancement New value added to drive a business result v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 13, 2020
@rashmivkulkarni rashmivkulkarni self-assigned this Mar 13, 2020
@rashmivkulkarni rashmivkulkarni requested a review from LeeDr March 13, 2020 19:03
TileMap and RegionMap are on OSS but not on x-pack because it has Maps.
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I checked that tile map and region map tests ran and passed on Jenkins

@rashmivkulkarni rashmivkulkarni merged commit 4b2231d into elastic:master Mar 13, 2020
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Mar 13, 2020
* OSS logic added

* reverting the logic of isOSS()

TileMap and RegionMap are on OSS but not on x-pack because it has Maps.
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Mar 13, 2020
* OSS logic added

* reverting the logic of isOSS()

TileMap and RegionMap are on OSS but not on x-pack because it has Maps.
rashmivkulkarni added a commit that referenced this pull request Mar 14, 2020
* OSS logic added

* reverting the logic of isOSS()

TileMap and RegionMap are on OSS but not on x-pack because it has Maps.
rashmivkulkarni added a commit that referenced this pull request Mar 14, 2020
* OSS logic added

* reverting the logic of isOSS()

TileMap and RegionMap are on OSS but not on x-pack because it has Maps.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 16, 2020
…o alerting/view-in-app

* 'alerting/view-in-app' of github.com:gmmorris/kibana: (33 commits)
  [SIEM] Adds 'Closes and opens signals' Cypress test (elastic#59950)
  [NP] Graph migration (elastic#59409)
  [ML] Clone analytics job  (elastic#59791)
  Move VALUE_CLICK_TRIGGER and APPLY_FILTER_TRIGGER to ui_action… (elastic#60202)
  Handle improperly defined Watcher Logging Action text parameter. (elastic#60169)
  Move select range trigger to uiActions (elastic#60168)
  [SIEM][CASES] Configure cases: Final (elastic#59358)
  Closes elastic#59784. Sets xpack.apm.serviceMapEnabled default value true. (elastic#60153)
  [siem/cypress] update junit filename to be picked up by runbld (elastic#60156)
  OSS logic added to test environment  (elastic#60134)
  Move canvas setup into app mount (elastic#59926)
  enable triggers_actions_ui plugin by default (elastic#60137)
  Expose Elasticsearch from start and deprecate from setup (elastic#59886)
  [SIEM] [Case] Insert timeline bugfix and limit 25 cases (elastic#60136)
  [ML] Client side cut over (elastic#60100)
  Disable query bar on service map routes (elastic#60118)
  Move subscribe_with_scope to kibana_legacy (elastic#59781)
  [Ingest] Agent Config create with sys monitoring (elastic#60111)
  [Watcher UI] Not possible to edit a watch that was created with the API if the ID contains a dot (elastic#59383)
  Actually fetch functionbeat fields needed for telemetry (elastic#60054)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 16, 2020
* master: (40 commits)
  skips 'config_open.ts' files from linter check (elastic#60248)
  [Searchprofiler] Spacing between rendered shards (elastic#60238)
  Add UiSettings validation & Kibana default route redirection (elastic#59694)
  [SIEM][CASE] Change configuration button (elastic#60229)
  [Step 1][App Arch] Saved object migrations from kibana plugin to new platform  (elastic#59044)
  adds new test (elastic#60064)
  [Uptime] Index Status API to Rest (elastic#59657)
  [SIEM] Adds 'Closes and opens signals' Cypress test (elastic#59950)
  [NP] Graph migration (elastic#59409)
  [ML] Clone analytics job  (elastic#59791)
  Move VALUE_CLICK_TRIGGER and APPLY_FILTER_TRIGGER to ui_action… (elastic#60202)
  Handle improperly defined Watcher Logging Action text parameter. (elastic#60169)
  Move select range trigger to uiActions (elastic#60168)
  [SIEM][CASES] Configure cases: Final (elastic#59358)
  Closes elastic#59784. Sets xpack.apm.serviceMapEnabled default value true. (elastic#60153)
  [siem/cypress] update junit filename to be picked up by runbld (elastic#60156)
  OSS logic added to test environment  (elastic#60134)
  Move canvas setup into app mount (elastic#59926)
  enable triggers_actions_ui plugin by default (elastic#60137)
  Expose Elasticsearch from start and deprecate from setup (elastic#59886)
  ...
@rashmivkulkarni rashmivkulkarni deleted the setOSS_boolean branch March 16, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants