Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up .eslintrc.js with better variable naming #59864

Merged
merged 1 commit into from
Mar 11, 2020

Conversation

watson
Copy link
Contributor

@watson watson commented Mar 11, 2020

I just introduced this variable (#59798) but realized after I merged the PR that I chose a bad name for the variable that might cause confusion. So this PR is just to fix that so it's easier to understand what's going on.

@watson watson added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 11, 2020
@watson watson requested a review from spalger March 11, 2020 07:19
@watson watson self-assigned this Mar 11, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@watson watson merged commit 3871798 into elastic:master Mar 11, 2020
@watson watson deleted the rename-eslint-const branch March 11, 2020 14:18
watson added a commit to watson/kibana that referenced this pull request Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants