[DOCS] Edits job creation UI text #59830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
v8.0.0
Feature:Data Frame Analytics
gchaps
reviewed
Mar 10, 2020
| @@ -610,7 +610,7 @@ export const CreateAnalyticsForm: FC<CreateAnalyticsFormProps> = ({ actions, sta | |||
| })} | |||
| helpText={i18n.translate('xpack.ml.dataframe.analytics.create.excludedFieldsHelpText', { | |||
| defaultMessage: | |||
| 'Optionally select fields to be excluded from analysis. All other supported fields will be included', | |||
| 'Select fields to exclude from analysis. All other supported fields are included.', | |||
There was a problem hiding this comment.
Is this sentence needed: All other supported fields are included.
There was a problem hiding this comment.
I think it's best keeping the second sentence in for clarity. Otherwise a user could think they need to manually exclude unsupported fields.
💚 Build SucceededTo update your PR or re-run it, just comment with: |
peteharverson
approved these changes
Mar 11, 2020
| @@ -610,7 +610,7 @@ export const CreateAnalyticsForm: FC<CreateAnalyticsFormProps> = ({ actions, sta | |||
| })} | |||
| helpText={i18n.translate('xpack.ml.dataframe.analytics.create.excludedFieldsHelpText', { | |||
| defaultMessage: | |||
| 'Optionally select fields to be excluded from analysis. All other supported fields will be included', | |||
| 'Select fields to exclude from analysis. All other supported fields are included.', | |||
There was a problem hiding this comment.
I think it's best keeping the second sentence in for clarity. Otherwise a user could think they need to manually exclude unsupported fields.
|
Pinging @elastic/ml-ui (:ml) |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
lcawl
added a commit
that referenced
this pull request
Mar 12, 2020
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Edits UI text in the data frame analytics job wizards.
Checklist
For maintainers
cc @gchaps