Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable all Mocha rules for tape tests #59798

Merged
merged 2 commits into from
Mar 11, 2020
Merged

ci: disable all Mocha rules for tape tests #59798

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0e059a
ci: disable all Mocha rules for tape tests
watson Mar 10, 2020
6b11892
prefix Mocha rules with 'mocha/'
watson Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ const ELASTIC_LICENSE_HEADER = `
*/
`;

const allMochaRules = {};
Object.keys(require('eslint-plugin-mocha').rules).forEach(k => (allMochaRules[k] = 'off'));
spalger marked this conversation as resolved.
Show resolved Hide resolved

module.exports = {
root: true,

Expand Down Expand Up @@ -519,9 +522,7 @@ module.exports = {
*/
{
files: ['test/harden/*.js'],
rules: {
'mocha/handle-done-callback': 'off', // TODO: Find a way to disable all mocha rules
},
rules: allMochaRules,
},

/**
Expand Down