-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Ml detection of duration anomalies #59785
[Uptime] Ml detection of duration anomalies #59785
Conversation
…uration-anamolies
@jgowdyelastic i took care of your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ML code changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App Arch code change LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke testing summary:
- I loaded the page as a super user and made sure that ML worked with a platinum/trial license, and that it was not enabled for lower license levels.
- I defined two spaces, one with access to ML and one without, and made sure users with sufficient permissions could define anomaly detection jobs, and that the feature was disabled otherwise.
- I made sure I could navigate to the ML plugin and view the jobs I've defined.
- I didn't observe anomalies myself, because my dataset was insufficient. I've seen this part of the feature demoed and it seems to work, but we should have a long-term testing cluster available that we can point our dev builds to.
Additional functional feedback I encountered while testing:
Not something to hold the review up on, but an enhancement we can add later: I activated a trial license and came back here. I closed the flyout and re-opened it and assumed the state would change to reflect the new license. We should see if it's possible to get that updated license state without refreshing the page (maybe after NP migration):
When trying to create an ML job with a user with insufficient permissions, I am noticing that the button is disabled (good) but we can probably make it better by adding an explanation via a tooltip. I'm fine with discussing this as a separate design issue that we'd address in a follow-up.
Note
I'm approving this now to get that out of the way, I have found several minor things like typoes and spacing issues that should be adjusted. Assuming there won't be any more large changes I am LGTM WFG on this one.
x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/translations.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/ml_flyout.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/uptime/public/components/functional/charts/duration_chart.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/uptime/public/components/functional/charts/duration_chart.tsx
Outdated
Show resolved
Hide resolved
...gacy/plugins/uptime/public/components/monitor_details/ml/__tests__/ml_integerations.test.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/ml_job_link.tsx
Show resolved
Hide resolved
x-pack/legacy/plugins/uptime/public/components/monitor_details/ml/translations.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/uptime/public/state/effects/__tests__/fecth_effect.test.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/uptime/public/state/effects/__tests__/fecth_effect.test.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/uptime/public/state/effects/__tests__/fecth_effect.test.ts
Show resolved
Hide resolved
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* add flyout * add state * update state * ad job * update * updat * add ml analyze button * update api * use differential colors for duration chart * remove duration chart gql * update type * type fix * fix tyoe * update translation * update test * update conflicts * update anomaly record * chart * added annotations * update error handling * update * update types * fixed types * fix types * update types * update * update * remove unnecessary change * remove unnecessary change * fix type * update * save * update pr * update tets * update job deletion * update * update tets * upadte tests * fix types * update title text * update types * fixed tests * update tests and types * updated types * fix PR feedback * unit test * update more types * update test and manage job * resolve conflicts * types * remove unnecessary change * revert ml code * revert ml code * fixed formatting issues pointed by pr feedback
* add flyout * add state * update state * ad job * update * updat * add ml analyze button * update api * use differential colors for duration chart * remove duration chart gql * update type * type fix * fix tyoe * update translation * update test * update conflicts * update anomaly record * chart * added annotations * update error handling * update * update types * fixed types * fix types * update types * update * update * remove unnecessary change * remove unnecessary change * fix type * update * save * update pr * update tets * update job deletion * update * update tets * upadte tests * fix types * update title text * update types * fixed tests * update tests and types * updated types * fix PR feedback * unit test * update more types * update test and manage job * resolve conflicts * types * remove unnecessary change * revert ml code * revert ml code * fixed formatting issues pointed by pr feedback
* master: Updating our direct usage of https-proxy-agent to 5.0.0 (elastic#58296) allow users to unset the throttle of an alert (elastic#60964) [Lens] Fix bug in metric config panel (elastic#60982) [SearchProfiler] Minor fixes (elastic#60919) [ML] Renaming ML setup and start contracts (elastic#60980) introduce StartServicesAccessor type for `CoreSetup.getStartServices` (elastic#60748) [SIEM][Detection Engine] Add rule's notification alert type (elastic#60832) [APM] Re-revert "Collect telemetry about data/API performance" (elastic#61030) [NP] Graph: get rid of saved objects class wrapper (elastic#59917) [EPM] merge duplicate fields when creating index patterns (elastic#60957) [Uptime] Ml detection of duration anomalies (elastic#59785) [Alerting] removes unimplemented buttons from Alert Details page (elastic#60934) [skip-ci] Fix CODEOWNERS paths for the Pulse team (elastic#60944) [APM] Threshold alerts (elastic#59566) [ML] Add support for percentiles aggregation to Transform wizard (elastic#60763) Cahgen save object duplicate message (elastic#60901)
Summary
Fixes: #60619
Ml detection of duration anomalies
Testing:
User can enable Anomaly detection on duration chart of each monitor by clicking enable anomaly detection
if they don't have ML feature available they will see the flyout with asking to start Trial
Otherwise, they can create job by clicking create new job
Checklist
Delete any items that are not applicable to this PR.
For maintainers