Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Functional tests - re-activate date_nanos test #59649

Merged
merged 2 commits into from
Mar 10, 2020
Merged

[ML] Functional tests - re-activate date_nanos test #59649

merged 2 commits into from
Mar 10, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Mar 9, 2020 •
edited
Loading

Summary

This PR re-activates the date_nanos functional UI test.

The failure couldn't be reproduced any more, see below.

Closes #59419

@pheyos pheyos self-assigned this Mar 9, 2020
@pheyos
Copy link
Member Author

pheyos commented Mar 9, 2020 •
edited
Loading

Reproducing the issue in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/228/ ...
No failure in 20 runs.

@pheyos
Copy link
Member Author

pheyos commented Mar 9, 2020 •
edited
Loading

Trying to reproduce the failure again in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/232/ ...
No failure in 40 runs.

And also in https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/233/ ...
No failure in 40 runs.

@pheyos
Copy link
Member Author

pheyos commented Mar 10, 2020

Summary: No failure in 100 runs.
It seems the issue doesn't reproduce any more. I'll re-enable the test as is.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pheyos pheyos changed the title [ML] Functional tests - stabilize date_nanos test [ML] Functional tests - re-activate date_nanos test Mar 10, 2020
@pheyos pheyos added :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.7.0 v8.0.0 labels Mar 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos pheyos marked this pull request as ready for review March 10, 2020 10:10
@pheyos pheyos requested a review from a team as a code owner March 10, 2020 10:10
peteharverson
peteharverson approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos
Copy link
Member Author

pheyos commented Mar 10, 2020 •
edited
Loading

Tested again with the whole suite (to make sure that there's no cross-test dependency that made the test fail): https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/234/
No failure in 40 runs.

@pheyos pheyos merged commit 848188e into elastic:master Mar 10, 2020
@pheyos pheyos deleted the fix_date_nanos_test branch March 10, 2020 13:15
@pheyos pheyos mentioned this pull request Mar 10, 2020
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request Mar 10, 2020
@pheyos
[ML] Functional tests - re-activate date_nanos test (elastic#59649)
68693ba 
This PR re-activates the date_nanos functional UI test.
pheyos added a commit that referenced this pull request Mar 10, 2020
@pheyos
[ML] Functional tests - re-activate date_nanos test (#59649) (#59748)
dd71ef1 
This PR re-activates the date_nanos functional UI test.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 10, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
dd5ae27 
* master:
  Add a retry to dashboard test for a sometimes slow async operation (elastic#59600)
  [Endpoint] Sample data generator for endpoint app (elastic#58936)
  [Vis Editor] Refactoring metrics axes (elastic#59135)
  [DOCS] Changed Discover app to Discover (elastic#59769)
  [Metrics Alerts] Add support for search query and groupBy on alerts (elastic#59388)
  Enhancement - EUICodeEditor for Visualize JSON  (elastic#58679)
  [ML] Transforms: Data grid fixes. (elastic#59538)
  [SIEM] Fix and consolidate handling of error responses in the client (elastic#59438)
  [Maps] convert tooltip classes to typescript (elastic#59589)
  [ML] Functional tests - re-activate date_nanos test (elastic#59649)
  Move canvas to use NP Expressions service (elastic#58387)
  Update misc dependencies (elastic#59542)
  [Unit Testing] Configure react-testing-library queries to use Kibana's data-test-subj instead of default data-testid (elastic#59445)
  [Console] Remove unused code (elastic#59554)
  [Logs / Metrics UI] Link handling / stop page reloads (elastic#58478)
  Add SavedObject management section registration in core  (elastic#59291)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

@walterra walterra Awaiting requested review from walterra

Assignees

@pheyos pheyos

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@pheyos @kibanamachine @elasticmachine @peteharverson