Explicit exports from search service #59620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizozom
added
Feature:New Platform
v8.0.0
Team:AppArch
release_note:skip
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
8 tasks
lizozom
commented
Mar 8, 2020
| @@ -19,7 +19,8 @@ | |||
|
|
|||
| import { getIndices } from './get_indices'; | |||
| import { IndexPatternCreationConfig } from './../../../../../../../management/public'; | |||
| import { LegacyApiCaller } from '../../../../../../../../../plugins/data/public'; | |||
| // eslint-disable-next-line @kbn/eslint/no-restricted-paths | |||
| import { LegacyApiCaller } from '../../../../../../../../../plugins/data/public/search'; | |||
There was a problem hiding this comment.
I changed the import to an internal one here, as this should go away anyway.
I will do a cleanup of other unnecessary imports in follow up PRs as we move the rest of the search \ agg config code into the plugin.
💚 Build SucceededTo update your PR or re-run it, just comment with: |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Mar 9, 2020
lizozom
pushed a commit
that referenced
this pull request
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #57434
Explicit exports from search service
Checklist
Delete any items that are not applicable to this PR.
For maintainers