[APM] Threshold alerts #59566
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,4 @@ | ||
| { | ||
| "items": [ | ||
| { | ||
| "message": "About to blow up!", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License; | ||
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
| import React from 'react'; | ||
| import { AlertType } from '../../../../../../../../../plugins/apm/common/alert_types'; | ||
| import { AlertAdd } from '../../../../../../../../../plugins/triggers_actions_ui/public'; | ||
|
|
||
| type AlertAddProps = React.ComponentProps<typeof AlertAdd>; | ||
|
There was a problem hiding this comment. This is such an underrated ts helper |
||
|
|
||
| interface Props { | ||
| addFlyoutVisible: AlertAddProps['addFlyoutVisible']; | ||
| setAddFlyoutVisibility: AlertAddProps['setAddFlyoutVisibility']; | ||
| alertType: AlertType | null; | ||
| } | ||
|
|
||
| export function AlertingFlyout(props: Props) { | ||
| const { addFlyoutVisible, setAddFlyoutVisibility, alertType } = props; | ||
|
|
||
| return alertType ? ( | ||
| <AlertAdd | ||
| addFlyoutVisible={addFlyoutVisible} | ||
| setAddFlyoutVisibility={setAddFlyoutVisibility} | ||
| consumer="apm" | ||
| alertTypeId={alertType} | ||
| canChangeTrigger={false} | ||
| /> | ||
| ) : null; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,146 @@ | ||||||
| /* | ||||||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||||||
| * or more contributor license agreements. Licensed under the Elastic License; | ||||||
| * you may not use this file except in compliance with the Elastic License. | ||||||
| */ | ||||||
|
|
||||||
| import { | ||||||
| EuiButtonEmpty, | ||||||
| EuiContextMenu, | ||||||
| EuiPopover, | ||||||
| EuiContextMenuPanelDescriptor | ||||||
| } from '@elastic/eui'; | ||||||
| import { i18n } from '@kbn/i18n'; | ||||||
| import React, { useState } from 'react'; | ||||||
| import { AlertType } from '../../../../../../../../plugins/apm/common/alert_types'; | ||||||
| import { AlertingFlyout } from './AlertingFlyout'; | ||||||
| import { useApmPluginContext } from '../../../../hooks/useApmPluginContext'; | ||||||
|
|
||||||
| const alertLabel = i18n.translate( | ||||||
| 'xpack.apm.serviceDetails.alertsMenu.alerts', | ||||||
| { | ||||||
| defaultMessage: 'Alerts' | ||||||
| } | ||||||
| ); | ||||||
|
|
||||||
| const createThresholdAlertLabel = i18n.translate( | ||||||
| 'xpack.apm.serviceDetails.alertsMenu.createThresholdAlert', | ||||||
| { | ||||||
| defaultMessage: 'Create threshold alert' | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| } | ||||||
| ); | ||||||
|
|
||||||
| const CREATE_THRESHOLD_ALERT_PANEL_ID = 'create_threshold'; | ||||||
|
|
||||||
| interface Props { | ||||||
| canReadAlerts: boolean; | ||||||
| canSaveAlerts: boolean; | ||||||
| } | ||||||
|
|
||||||
| export function AlertIntegrations(props: Props) { | ||||||
| const { canSaveAlerts, canReadAlerts } = props; | ||||||
|
|
||||||
| const plugin = useApmPluginContext(); | ||||||
|
|
||||||
| const [popoverOpen, setPopoverOpen] = useState(false); | ||||||
|
|
||||||
| const [alertType, setAlertType] = useState<AlertType | null>(null); | ||||||
|
|
||||||
| const button = ( | ||||||
| <EuiButtonEmpty | ||||||
| iconType="arrowDown" | ||||||
| iconSide="right" | ||||||
| onClick={() => setPopoverOpen(true)} | ||||||
| > | ||||||
| {i18n.translate('xpack.apm.serviceDetails.alertsMenu.alerts', { | ||||||
| defaultMessage: 'Alerts' | ||||||
| })} | ||||||
| </EuiButtonEmpty> | ||||||
| ); | ||||||
|
|
||||||
| const panels: EuiContextMenuPanelDescriptor[] = [ | ||||||
| { | ||||||
| id: 0, | ||||||
| title: alertLabel, | ||||||
| items: [ | ||||||
| ...(canSaveAlerts | ||||||
| ? [ | ||||||
| { | ||||||
| name: createThresholdAlertLabel, | ||||||
| panel: CREATE_THRESHOLD_ALERT_PANEL_ID, | ||||||
| icon: 'bell' | ||||||
| } | ||||||
| ] | ||||||
| : []), | ||||||
| ...(canReadAlerts | ||||||
| ? [ | ||||||
| { | ||||||
| name: i18n.translate( | ||||||
| 'xpack.apm.serviceDetails.alertsMenu.viewActiveAlerts', | ||||||
| { | ||||||
| defaultMessage: 'View active alerts' | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| } | ||||||
| ), | ||||||
| href: plugin.core.http.basePath.prepend( | ||||||
| '/app/kibana#/management/kibana/triggersActions/alerts' | ||||||
| ), | ||||||
| icon: 'tableOfContents' | ||||||
| } | ||||||
| ] | ||||||
| : []) | ||||||
| ] | ||||||
| }, | ||||||
| { | ||||||
| id: CREATE_THRESHOLD_ALERT_PANEL_ID, | ||||||
| title: createThresholdAlertLabel, | ||||||
| items: [ | ||||||
| { | ||||||
| name: i18n.translate( | ||||||
| 'xpack.apm.serviceDetails.alertsMenu.transactionDuration', | ||||||
| { | ||||||
| defaultMessage: 'Transaction duration' | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| } | ||||||
| ), | ||||||
| onClick: () => { | ||||||
| setAlertType(AlertType.TransactionDuration); | ||||||
| } | ||||||
| }, | ||||||
| { | ||||||
| name: i18n.translate( | ||||||
| 'xpack.apm.serviceDetails.alertsMenu.errorRate', | ||||||
| { | ||||||
| defaultMessage: 'Error rate' | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| } | ||||||
| ), | ||||||
| onClick: () => { | ||||||
| setAlertType(AlertType.ErrorRate); | ||||||
| } | ||||||
| } | ||||||
| ] | ||||||
| } | ||||||
| ]; | ||||||
|
|
||||||
| return ( | ||||||
| <> | ||||||
| <EuiPopover | ||||||
| id="integrations-menu" | ||||||
| button={button} | ||||||
| isOpen={popoverOpen} | ||||||
| closePopover={() => setPopoverOpen(false)} | ||||||
| panelPaddingSize="none" | ||||||
| anchorPosition="downRight" | ||||||
| > | ||||||
| <EuiContextMenu initialPanelId={0} panels={panels} /> | ||||||
| </EuiPopover> | ||||||
| <AlertingFlyout | ||||||
| alertType={alertType} | ||||||
| addFlyoutVisible={!!alertType} | ||||||
| setAddFlyoutVisibility={visible => { | ||||||
| if (!visible) { | ||||||
| setAlertType(null); | ||||||
| } | ||||||
| }} | ||||||
| /> | ||||||
| </> | ||||||
| ); | ||||||
| } | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apm_writeuses snake_case. Should we stay consistent?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw. Should
apmbe renamed toapm_read?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah..
actions-readis what's defined in the Action app endpoints...My mind is a little hazy on this mapping concept. Are we mapping tags to privileges here? How does it work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understood it last time I looked into it, but that was last year. It seems this mapping concept is not immediately intuitive so adding some comments (albeit a bit verbose) might be a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would just linking to
x-pack/plugins/features/common/feature_kibana_privileges.tswhere it's explained be OK? Rather than copying documentation between files?