-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harden process.env #59280
Harden process.env #59280
Conversation
4f3b0f6
to
00b2c3c
Compare
Pinging @elastic/kibana-security (Team:Security) |
00b2c3c
to
bbcd78d
Compare
bbcd78d
to
3c3e59a
Compare
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/management/_handle_alias·js.management Index patterns on aliases should be able to discover and verify no of hits for alias2Standard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, flaky test was skipped in master recently.
do u mind adjusting the labels @watson , I see this is still a draft PR, but has 7.17.1 label which is going out today. Thanks. |
Depends on #55697 - Once that lands, I'll rebase this PR at which time only the last commit is relevant.This PR was originally part of #55697 - for the previous discussion about this code, see that PR.
This PR hardens the
process.env
property to not be susceptible to prototype pollution fromObject.prototype
.