Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move mouse to close obstructing tooltip #59214

Merged
merged 2 commits into from
Mar 4, 2020
Merged

move mouse to close obstructing tooltip #59214

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80759f1
move mouse to close obstructing tooltip
Mar 3, 2020
d8dec79
Merge branch 'master' into fixDiscoverTooltip
elasticmachine Mar 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/functional/page_objects/discover_page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ export function DiscoverPageProvider({ getService, getPageObjects }) {
}

async clickLoadSavedSearchButton() {
await testSubjects.moveMouseTo('discoverOpenButton');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to have this internally but looks like it was commented out:

Screen Shot 2020-03-04 at 10 06 03 AM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented it out during Leadfoot -> Webdriver migration, since many tests were failing on moveMouseTo.
The plan was to find a reason for that issue, but the easiest way was to keep it commented out.
Now I think we need to remove it to avoid confusion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw people adding moveMouseTo in some test/method explicitly and it looks reasonable and easy to follow.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stacey-gammon would you like me to remove the commented out moveMouseTo line in this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up to you, just was pointing it out, changes LGTM!

await testSubjects.click('discoverOpenButton');
}

Expand Down