Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multiple problems with discover 'should show the correct bar char… #5919

Merged
merged 3 commits into from
Jan 15, 2016
Merged

Fix multiple problems with discover 'should show the correct bar char… #5919

merged 3 commits into from
Jan 15, 2016

Conversation

LeeDr
Copy link

@LeeDr LeeDr commented Jan 15, 2016

One discover test wasn't really checking the data.

  • The test was using array.size instead of array.length so it wasn't iterating through the data to check it.
  • This test was originally created before we switched to using UTC timezone so it wouldn't have passed on Jenkins.
  • I improved the discoverPage.getBarChartData. It's much simpler now and uses a better cssSelector that doesn't depend on matching the green color of the bars.

Fix multiple problems with discover 'should show the correct bar char…
cefbb5e 
…t'. UTC timezone, array.length, improve cssSelector.
@jbudz
Copy link
Member

jbudz commented Jan 15, 2016

jenkins, test it

1 similar comment
@LeeDr
Copy link
Author

LeeDr commented Jan 15, 2016

jenkins, test it

@jbudz
Copy link
Member

jbudz commented Jan 15, 2016

👍 , after jenkins passes this LGTM

@jbudz jbudz assigned LeeDr and unassigned jbudz Jan 15, 2016
LeeDr pushed a commit that referenced this pull request Jan 15, 2016
Merge pull request #5919 from LeeDr/fixDiscoverTest
d0298d7 
Fix multiple problems with discover 'should show the correct bar char…
@LeeDr LeeDr merged commit d0298d7 into elastic:master Jan 15, 2016
LeeDr pushed a commit that referenced this pull request Jan 15, 2016
Merge pull request #5922 from LeeDr/fixDiscoverTestv4.x
4a6cb3c 
Merge #5919 to Fix discover test v4.x
@LeeDr LeeDr deleted the fixDiscoverTest branch January 27, 2016 23:05
@santosomar santosomar mentioned this pull request Oct 28, 2023
Open
@larrycameron80 larrycameron80 mentioned this pull request Oct 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
review test v4.5.0 v5.0.0-alpha1 v5.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeeDr @jbudz @epixa