Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.6] [SIEM] Default the Timeline events filter to show All events (#58953) #59059

Merged

Conversation

andrew-goldstein
Copy link
Contributor

Backports the following commits to 7.6:

…#58953)

## [SIEM] Default the Timeline events filter to show All events

The Timeline events filter introduced in `7.6` to support the [detection engine](https://www.elastic.co/guide/en/siem/guide/current/detection-engine-overview.html) defaulted to filtering by `Raw events`, and thus required manually selecting `All events` or `Signal events` from the dropdown to view signals.

The new default is `All events`, per the screenshots below:

### Before
![event-filter-before](https://user-images.githubusercontent.com/4459398/75593223-ecc61500-5a41-11ea-8d7d-8db5eccb1eb4.png)

### After
![event-filter-after](https://user-images.githubusercontent.com/4459398/75593238-f5b6e680-5a41-11ea-9e12-2fc1232f58d1.png)
…type check, along with this note:

```
CAUTION: `eventType` is an optional prop in post-`7.6.x` branches. In later branches, `eventType`
is omitted from this test, to truly verify the new default from redux. In this branch, we must
specify `eventType` to pass the type check, but this is not the true intent of this test.
```
@andrew-goldstein andrew-goldstein self-assigned this Mar 3, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@andrew-goldstein andrew-goldstein merged commit e29a53f into elastic:7.6 Mar 3, 2020
@andrew-goldstein andrew-goldstein deleted the backport/7.6/pr-58953 branch March 3, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants