Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Transform: Fix advanced editor initialization. #59006

Merged
merged 4 commits into from
Mar 3, 2020
Merged

[ML] Transform: Fix advanced editor initialization. #59006

merged 4 commits into from
Mar 3, 2020

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Mar 2, 2020 •
edited
Loading

Summary

Fixes regression introduced by #58015 to correctly initialize the transform wizard advanced editor with the current configuration.

Checklist

For maintainers

@walterra walterra added bug Fixes for quality problems that affect the customer experience regression :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms v7.7.0 labels Mar 2, 2020
@walterra walterra requested a review from a team as a code owner March 2, 2020 09:21
@walterra walterra self-assigned this Mar 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra requested a review from pheyos March 2, 2020 10:17
pheyos
pheyos approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jgowdyelastic
jgowdyelastic approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@walterra walterra merged commit ecbcceb into elastic:master Mar 3, 2020
@walterra walterra deleted the ml-transform-fix-advanced-editor-init branch March 3, 2020 07:59
@walterra walterra mentioned this pull request Mar 3, 2020
Merged
walterra added a commit to walterra/kibana that referenced this pull request Mar 3, 2020
@walterra
[ML] Transform: Fix advanced editor initialization. (elastic#59006)
c0aa84a 
Fixes regression introduced by elastic#58015 to correctly initialize the transform wizard advanced editor with the current configuration.
walterra added a commit that referenced this pull request Mar 3, 2020
@walterra
[ML] Transform: Fix advanced editor initialization. (#59006) (#59114)
5a41051 
Fixes regression introduced by #58015 to correctly initialize the transform wizard advanced editor with the current configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@darnautov darnautov Awaiting requested review from darnautov

@peteharverson peteharverson Awaiting requested review from peteharverson

Assignees

@walterra walterra

Labels
bug Fixes for quality problems that affect the customer experience Feature:Transforms ML transforms :ml regression release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@walterra @elasticmachine @kibanamachine @pheyos @alvarezmelissa87 @jgowdyelastic