Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new search strategy service for search requests #58990

Merged
merged 5 commits into from
Mar 4, 2020
Merged

Use new search strategy service for search requests #58990

merged 5 commits into from
Mar 4, 2020

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Mar 1, 2020

Summary

Use new search strategy service for search requests instead of EsClient

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@lizozom lizozom requested a review from lukasolson March 1, 2020 15:56
@lizozom lizozom requested a review from a team as a code owner March 1, 2020 15:56
@lizozom lizozom self-assigned this Mar 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom
Copy link
Contributor Author

lizozom commented Mar 2, 2020

@elasticmachine merge upstream

@elasticmachine elasticmachine requested a review from a team March 2, 2020 07:52
kertal
kertal approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested the painless error of discover, works.

lukasolson
lukasolson approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lizozom
Copy link
Contributor Author

lizozom commented Mar 4, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lizozom lizozom merged commit 01e4b96 into elastic:master Mar 4, 2020
lizozom pushed a commit to lizozom/kibana that referenced this pull request Mar 4, 2020
@elasticmachine
Use new search strategy service for search requests (elastic#58990)
fbb29d6 
* Use new search strategy

* Update jest test

* fix painless error

Co-authored-by: Elastic Machine <[email protected]>
@lizozom lizozom mentioned this pull request Mar 4, 2020
Merged
lizozom pushed a commit that referenced this pull request Mar 4, 2020
@elasticmachine
Use new search strategy service for search requests (#58990) (#59292)
42bf122 
* Use new search strategy

* Update jest test

* fix painless error

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasolson lukasolson lukasolson approved these changes

@kertal kertal kertal approved these changes

Assignees

@lizozom lizozom

Labels
Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lizozom @elasticmachine @kibanamachine @kertal @lukasolson