Retry migration operations which fail due to snapshot in progress #58884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolf
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
pgayvallet
approved these changes
Feb 29, 2020
Comment on lines
-67
to
+68
| error instanceof esErrors.Gone | ||
| error instanceof esErrors.Gone || | ||
| error?.body?.error?.type === 'snapshot_in_progress_exception' |
There was a problem hiding this comment.
I know this is not on our side, but ES error handling seems like a mess...
|
@elasticmachine merge upstream |
|
CI previously passed but failed after merging master due to #58983 so going ahead and merging. |
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Mar 2, 2020
…astic#58884) Co-authored-by: Elastic Machine <[email protected]>
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Mar 2, 2020
…astic#58884) Co-authored-by: Elastic Machine <[email protected]>
rudolf
added a commit
that referenced
this pull request
Mar 2, 2020
…8884) (#59018) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
rudolf
added a commit
that referenced
this pull request
Mar 3, 2020
…ss (#58884) (#59019) * Retry migration operations which fail due to snapshot in progress (#58884) Co-authored-by: Elastic Machine <[email protected]> * Import APICaller type Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #47808
Related to: #52202
Release notes:
Fixes a bug that could cause saved object migrations to fail when an Elasticsearch snapshot is currently in progress.
Checklist
Delete any items that are not applicable to this PR.
For maintainers