Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Add field and style-meta types #58766

Merged
merged 18 commits into from
Mar 5, 2020

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Feb 27, 2020

#57908 revealed the need to make style and field-meta more flexible. Fields need to accommodate multiple style-metas (e.g. ranges and term-counts).

Rather than clutter that PR with new .ts boilerplate for the refactor, extracting some of those preliminaries here in a separate PR.

lint

restrict to fieldmeta

fix rename
@thomasneirynck thomasneirynck requested a review from a team as a code owner February 27, 2020 19:31
@thomasneirynck thomasneirynck added chore release_note:skip Skip the PR/issue when compiling release notes [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.7.0 v8.0.0 labels Feb 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck
Copy link
Contributor Author

After discussion with @nreese, waiting on #58791 to merge first.

@thomasneirynck thomasneirynck requested a review from nreese March 5, 2020 15:30
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI
code review

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck merged commit 46738cf into elastic:master Mar 5, 2020
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Mar 5, 2020
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 6, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

nreese pushed a commit that referenced this pull request Mar 7, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants