-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Add field and style-meta types #58766
[Maps] Add field and style-meta types #58766
Conversation
lint restrict to fieldmeta fix rename
Pinging @elastic/kibana-gis (Team:Geo) |
x-pack/legacy/plugins/maps/public/layers/styles/vector/style_meta.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_style_property.js
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_size_property.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style.test.js
Outdated
Show resolved
Hide resolved
...ck/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_color_property.test.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
code review
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
Co-authored-by: Elastic Machine <[email protected]>
#57908 revealed the need to make style and field-meta more flexible. Fields need to accommodate multiple style-metas (e.g. ranges and term-counts).
Rather than clutter that PR with new
.ts
boilerplate for the refactor, extracting some of those preliminaries here in a separate PR.