Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adding get records endpoint wrapper #58500

Merged
merged 1 commit into from
Feb 26, 2020
Merged

[ML] Adding get records endpoint wrapper #58500

merged 1 commit into from
Feb 26, 2020

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Feb 25, 2020 •
edited by peteharverson
Loading

Adding kibana endpoint wrapper for the get records endpoint.
https://www.elastic.co/guide/en/elasticsearch/reference/master/ml-get-record.html

@jgowdyelastic jgowdyelastic added review non-issue Indicates to automation that a pull request should not appear in the release notes :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Feb 25, 2020
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner February 25, 2020 17:07
@jgowdyelastic jgowdyelastic self-assigned this Feb 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@alvarezmelissa87
Copy link
Contributor

Thank you for writing the schema in the route file for now 🙏
It will save me some nasty merge conflicts 😆It can be moved to the appropriate schema file once the PR moving all those files has been merged 👌

peteharverson
peteharverson approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit 71254de into elastic:master Feb 26, 2020
@jgowdyelastic jgowdyelastic deleted the results-records-endpoint branch February 26, 2020 09:21
@jgowdyelastic jgowdyelastic mentioned this pull request Feb 26, 2020
Merged
walterra
walterra reviewed Feb 26, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 26, 2020
@jgowdyelastic
[ML] Adding get records endpoint wrapper (elastic#58500)
3e48940
jgowdyelastic added a commit that referenced this pull request Feb 26, 2020
@jgowdyelastic
[ML] Adding get records endpoint wrapper (#58500) (#58574)
94fb794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra left review comments

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@jgowdyelastic jgowdyelastic

Labels
Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgowdyelastic @elasticmachine @kibanamachine @alvarezmelissa87 @walterra @peteharverson